Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 43463e2bf5a4cdb791af779cb9e949f2d9be619b
https://github.com/WebKit/WebKit/commit/43463e2bf5a4cdb791af779cb9e949f2d9be619b
Author: Adrian Taylor <[email protected]>
Date: 2026-02-10 (Tue, 10 Feb 2026)
Changed paths:
M Configurations/CommonBase.xcconfig
Log Message:
-----------
Add clang-target argument
https://bugs.webkit.org/show_bug.cgi?id=307323
rdar://169955071
Reviewed by Elliott Williams.
This adds a -clang-target argument to all Swift compiles on MacOS. The reason
for this is that sometimes we may be using a later SDK but targeting an earlier
MacOS version. Swift interprets WebKit's C++ headers as clang modules, which
are intended to be agnostic to specific target versions. This agnosticism means
that macros such as __MAC_OS_X_VERSION_MIN_REQUIRED may not be correctly set
for the SDK target option, and thus data member offsets (and other things) may
be wrong. This is not OK for WebKit where we need these offsets to match
whether it's Swift or C++ interpreting a structure, and so we need to force
swift to ask clang to target a specific target version. The -clang-target
argument in this patch achieves that.
rdar://168992837 represents the underlying confusion here within the tooling.
Canonical link: https://commits.webkit.org/307153@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
