Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 63830c8668cf34ae45accbe05e4bb149fccfc488
https://github.com/WebKit/WebKit/commit/63830c8668cf34ae45accbe05e4bb149fccfc488
Author: Jer Noble <[email protected]>
Date: 2026-02-10 (Tue, 10 Feb 2026)
Changed paths:
A
LayoutTests/media/caption-display-settings/caption-display-settings-default-anchorBounds-expected.txt
A
LayoutTests/media/caption-display-settings/caption-display-settings-default-anchorBounds.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/html/HTMLVideoElementCaptionDisplaySettings.cpp
Log Message:
-----------
When HTMLVideoElement.showCaptionDisplaySettings() is called with no
arguments, menu is not anchored by cursor
rdar://165762212
https://bugs.webkit.org/show_bug.cgi?id=306899
Reviewed by Eric Carlson.
When an anchorTarget is not included in the dictionary parameter to
showCaptionDisplaySettings(),
do our best to provide a good place for the pop-up menu to be placed. We will
try in the following order:
- Current mouse or touch location if the current event is a mouse or touch event
- Current event target if not
- Otherwise, the last known mouse location
Test:
media/caption-display-settings/caption-display-settings-default-anchorBounds.html
*
LayoutTests/media/caption-display-settings/caption-display-settings-default-anchorBounds-expected.txt:
Added.
*
LayoutTests/media/caption-display-settings/caption-display-settings-default-anchorBounds.html:
Added.
* Source/WebCore/html/HTMLVideoElementCaptionDisplaySettings.cpp:
(WebCore::HTMLVideoElementCaptionDisplaySettings::showCaptionDisplaySettings):
Canonical link: https://commits.webkit.org/307185@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
