Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 06cd23df2a6b11c0f6a55405407f8de4f554b3a2
https://github.com/WebKit/WebKit/commit/06cd23df2a6b11c0f6a55405407f8de4f554b3a2
Author: Yulun Wu <[email protected]>
Date: 2026-02-11 (Wed, 11 Feb 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.cpp
M Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.h
Log Message:
-----------
[GFC] Refactor ImplicitGrid helper methods for auto-placement
https://bugs.webkit.org/show_bug.cgi?id=307487
<rdar://170098699>
Reviewed by Sammy Gill.
Some ImplicitGrid helper functions that are only used for definite row items
are named in a way that would conflict with what we will want to do for
auto-positioned items. We should refactor these functions names to
specify they are for definite row items to avoid mixups.
* Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.cpp:
(WebCore::Layout::ImplicitGrid::insertDefiniteRowItem):
(WebCore::Layout::ImplicitGrid::findColumnPositionForDefiniteRowItem const):
(WebCore::Layout::ImplicitGrid::growGridColumnsToFit):
(WebCore::Layout::ImplicitGrid::verifyHasEmptyLastColumn const):
(WebCore::Layout::ImplicitGrid::findColumnPosition const): Deleted.
(WebCore::Layout::ImplicitGrid::growGridToFit): Deleted.
* Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.h:
Canonical link: https://commits.webkit.org/307284@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
