Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ec69ce43e97a9bbbcec1617a7cc73719af17426
https://github.com/WebKit/WebKit/commit/5ec69ce43e97a9bbbcec1617a7cc73719af17426
Author: Phinehas Fuachie <[email protected]>
Date: 2026-02-11 (Wed, 11 Feb 2026)
Changed paths:
A
LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-rtl-volume-button-no-overlap-expected.txt
A
LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-rtl-volume-button-no-overlap.html
M
Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
Log Message:
-----------
The mute button overlaps with the volume bar in native fullscreen
https://bugs.webkit.org/show_bug.cgi?id=307474
rdar://169711449
Reviewed by Jer Noble.
Use flexbox with gap instead of absolute positioning for the volume controls in
the new fullscreen
controls to prevent overlap in RTL languages and use absolute positioning(to
avoid complications)
to prevent overlap in the old fullscreen controls.
*
LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-rtl-volume-button-no-overlap-expected.txt:
Added.
*
LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-rtl-volume-button-no-overlap.html:
Added.
*
Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:
(.media-controls.mac.fullscreen:not(.uses-ltr-user-interface-layout-direction)
.buttons-container.left .mute.bar):
(.media-controls.mac.fullscreen:not(.uses-ltr-user-interface-layout-direction)
.buttons-container.left):
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::macOSFullscreenMediaControlsStyleSheet):
Canonical link: https://commits.webkit.org/307301@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
