Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 324154a54293995c37cfeb06366f9cfdf60906ab
https://github.com/WebKit/WebKit/commit/324154a54293995c37cfeb06366f9cfdf60906ab
Author: Ben Nham <[email protected]>
Date: 2026-02-11 (Wed, 11 Feb 2026)
Changed paths:
M Source/WebKit/NetworkProcess/Notifications/WebPushDaemonConnection.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm
Log Message:
-----------
GetPushSubscription should throw AbortError on webpushd connection error
https://bugs.webkit.org/show_bug.cgi?id=307485
rdar://170097738
Reviewed by Brady Eidson.
GetPushSubscription throws an IndexSizeError if there's a connection error to
webpushd. Make it
throw an AbortError instead to match the behavior of subscribe.
Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm
* Source/WebKit/NetworkProcess/Notifications/WebPushDaemonConnection.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
(TestWebKitAPI::(WebPushDTest,
GetPushSubscriptionWithBadIPCVersionRaisesExceptionTest)):
Canonical link: https://commits.webkit.org/307304@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications