Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 196fcc85b39ee2362c6c7492fabbb1b9d4983509
https://github.com/WebKit/WebKit/commit/196fcc85b39ee2362c6c7492fabbb1b9d4983509
Author: Sergio Villar Senin <[email protected]>
Date: 2026-02-11 (Wed, 11 Feb 2026)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/platform/xr/PlatformXR.h
A Source/WebCore/platform/xr/XRHitTestSourceIdentifier.h
M Source/WebCore/testing/WebFakeXRDevice.cpp
M Source/WebCore/testing/WebFakeXRDevice.h
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
M Source/WebKit/Shared/WTFArgumentCoders.serialization.in
M Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.cpp
Log Message:
-----------
[SaferCPP] Use ObjectIdentifier for hit test source ids
https://bugs.webkit.org/show_bug.cgi?id=307322
Reviewed by Fujii Hironori.
As per the SaferCPP guidelines we should use object identifiers instead
of uints for ids. Using weakly-typed identifiers such as uint64_t leads
to confusion between identifier types and bugs.
No new tests as this does not affect funcionality.
* Source/WebCore/Headers.cmake:
* Source/WebCore/platform/xr/PlatformXR.h:
* Source/WebCore/platform/xr/XRHitTestSourceIdentifier.h: Added.
* Source/WebCore/testing/WebFakeXRDevice.cpp:
(WebCore::SimulatedXRDevice::requestHitTestSource):
(WebCore::SimulatedXRDevice::requestTransientInputHitTestSource):
* Source/WebCore/testing/WebFakeXRDevice.h:
* Source/WebKit/Scripts/webkit/messages.py:
(serialized_identifiers):
* Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp:
(IPC::serializedIdentifiers):
* Source/WebKit/Shared/WTFArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.cpp:
(WebKit::OpenXRCoordinator::requestHitTestSource):
(WebKit::OpenXRCoordinator::requestTransientInputHitTestSource):
Canonical link: https://commits.webkit.org/307341@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
