Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6b34ac51510516bd6a3ec2f5edc97413758d3ab1
https://github.com/WebKit/WebKit/commit/6b34ac51510516bd6a3ec2f5edc97413758d3ab1
Author: Sammy Gill <[email protected]>
Date: 2026-02-12 (Thu, 12 Feb 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/grid/TrackSizingAlgorithm.cpp
M Source/WebCore/layout/integration/grid/LayoutIntegrationGridCoverage.cpp
Log Message:
-----------
[GFC][Integration] Allow max-content as track sizing function for columns
https://bugs.webkit.org/show_bug.cgi?id=307629
rdar://170193665
Reviewed by Vitor Roriz.
TrackSizingAlgorithm should be able to perform track sizing with
max-content as the track sizing function. We can ease the GFC
restrictions a bit by allowing content that has this as part of its
columns track sizing functions list.
This allows content like the following to run through GFC:
<div style="display: grid; width: 100px; height: 100px; grid-template-columns:
max-content max-content; grid-template-rows: 20px; min-width: 0; min-height: 0;
outline: 1px solid green;">
<div style="outline: 1px solid red; grid-column: 1/2; grid-row: 1/2;
min-width: 0; min-height: 0;">x x x x</div>
<div style="outline: 1px solid red; grid-column: 2/3; grid-row: 1/2;
min-width: 0; min-height: 0;">xxxxxxxxx</div>
</div>
* Source/WebCore/layout/formattingContexts/grid/TrackSizingAlgorithm.cpp:
(WebCore::Layout::sizeTracksToFitNonSpanningItems):
Needed to change this ASSERT_NOT_IMPLEMENTED_YET() to notImplemented()
to avoid debug crashes since we called it unconditionally.
Canonical link: https://commits.webkit.org/307372@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications