Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c839a88ec84718126aa70cbcbde53feaea7be3d7
      
https://github.com/WebKit/WebKit/commit/c839a88ec84718126aa70cbcbde53feaea7be3d7
  Author: Wenson Hsieh <[email protected]>
  Date:   2026-02-12 (Thu, 12 Feb 2026)

  Changed paths:
    M LayoutTests/fast/text-extraction/debug-text-extraction-basic-expected.txt
    M LayoutTests/fast/text-extraction/debug-text-extraction-basic.html
    M LayoutTests/fast/text-extraction/debug-text-extraction-form-controls.html
    M LayoutTests/fast/text-extraction/debug-text-extraction-highlight-text.html
    M LayoutTests/fast/text-extraction/debug-text-extraction-interactions.html
    M 
LayoutTests/fast/text-extraction/debug-text-extraction-lightweight-discretionary.html
    M LayoutTests/fast/text-extraction/debug-text-extraction-lightweight.html
    M LayoutTests/fast/text-extraction/debug-text-extraction-markup.html
    M Source/WebCore/page/text-extraction/TextExtraction.cpp
    M Source/WebCore/page/text-extraction/TextExtractionTypes.h
    M Source/WebKit/Shared/TextExtractionToStringConversion.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.mm
    M 
Source/WebKit/UIProcess/Cocoa/TextExtraction/WKWebView+TextExtraction.swift
    M Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
    M Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
    M Tools/TestRunnerShared/UIScriptContext/UIScriptControllerShared.cpp
    M Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm

  Log Message:
  -----------
  [AutoFill Debugging] Allow clients to extract specific event listener 
categories
https://bugs.webkit.org/show_bug.cgi?id=307684
rdar://problem/170245590

Reviewed by Abrar Rahman Protyasha.

Replace the `includeEventListeners` boolean flag with an options enumeration 
which encompasses
various event listener types; this allows clients to request only specific 
types of event handlers.

* LayoutTests/fast/text-extraction/debug-text-extraction-basic-expected.txt:
* LayoutTests/fast/text-extraction/debug-text-extraction-basic.html:
* LayoutTests/fast/text-extraction/debug-text-extraction-form-controls.html:
* LayoutTests/fast/text-extraction/debug-text-extraction-highlight-text.html:
* LayoutTests/fast/text-extraction/debug-text-extraction-interactions.html:
* 
LayoutTests/fast/text-extraction/debug-text-extraction-lightweight-discretionary.html:
* LayoutTests/fast/text-extraction/debug-text-extraction-lightweight.html:
* LayoutTests/fast/text-extraction/debug-text-extraction-markup.html:

Adjust layout tests to use the new property.

* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::extractRecursive):
(WebCore::TextExtraction::extractItem):
* Source/WebCore/page/text-extraction/TextExtractionTypes.h:
* Source/WebKit/Shared/TextExtractionToStringConversion.cpp:
(WebKit::partsForItem):

In the case where there's only a single item, make this attribute easier to 
read by omitting the
square brackets representing a list.

* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(coreEventListenerCategories):
(-[WKWebView _requestTextExtractionInternal:completion:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.mm:
(-[_WKTextExtractionConfiguration _initForOnlyVisibleText:]):
(-[_WKTextExtractionConfiguration includeEventListeners]):
(-[_WKTextExtractionConfiguration setIncludeEventListeners:]):

Leave the old property intact, since it's still used by some internal clients; 
make it simply map to
either the `.none` or `.all` value of `eventListenerCategories`.

(-[_WKTextExtractionConfiguration setEventListenerCategories:]):
* Source/WebKit/UIProcess/Cocoa/TextExtraction/WKWebView+TextExtraction.swift:
* Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:
* Tools/TestRunnerShared/UIScriptContext/UIScriptControllerShared.cpp:
(WTR::toTextExtractionTestOptions):
* Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
(WTR::eventListenerCategories):
(WTR::createTextExtractionConfiguration):

Canonical link: https://commits.webkit.org/307400@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to