Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ce27b7cfad2d3183419286d634d9c12bf50bd1e7
https://github.com/WebKit/WebKit/commit/ce27b7cfad2d3183419286d634d9c12bf50bd1e7
Author: Elliott Williams <[email protected]>
Date: 2026-02-12 (Thu, 12 Feb 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm
Log Message:
-----------
REGRESSION(Xcode 26): Broke WebPushD tests (ASSERTION FAILED:
m_shouldIncrementProtocolVersionForTesting)
https://bugs.webkit.org/show_bug.cgi?id=307362
rdar://169991396
Reviewed by Mike Wyrzykowski.
At-desk-style builds produce a flat build directory structure and
require setting both DYLD_FRAMEWORK_PATH and DYLD_LIBRARY_PATH in all
the executables we spawn. Test code for webpushd was only setting the
former. Now that webpushd can pull in strictly safe Swift code, on older
platforms it requires loading the libswiftCompatibilitySpan.dylib
compatibility runtime. So, it needs DYLD_LIBRARY_PATH set too.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
(TestWebKitAPI::testDaemonPList): While we do not observe the same crash
in adattributiond, this is the same loading logic, so add
DYLD_LIBRARY_PATH here too for correctness.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
(TestWebKitAPI::testWebPushDaemonPList):
Canonical link: https://commits.webkit.org/307416@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
