Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0a6dd388232482df1f9c2ff58e57652ebc49f13
      
https://github.com/WebKit/WebKit/commit/b0a6dd388232482df1f9c2ff58e57652ebc49f13
  Author: Tyler Wilcock <[email protected]>
  Date:   2026-02-12 (Thu, 12 Feb 2026)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/custom-elements/element-internals-aria-element-reflection-expected.txt
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/dom/CustomElementDefaultARIA.cpp
    M Source/WebCore/dom/CustomElementDefaultARIA.h

  Log Message:
  -----------
  AX: Setting null on an ElementInternals ARIA reflection property should fully 
clear any previous value
https://bugs.webkit.org/show_bug.cgi?id=307286
rdar://169929531

Reviewed by Anne van Kesteren.

When ARIA element reflection array properties (ariaControlsElements, 
ariaDescribedByElements, etc.)
on ElementInternals were set to null, subsequently getting them returned an 
empty array instead of
null. This was because setElementsForAttribute stored an empty vector in the 
map when null was
passed, rather than removing the entry entirely.

* 
LayoutTests/imported/w3c/web-platform-tests/custom-elements/element-internals-aria-element-reflection-expected.txt:
Mark testcase as passing.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::addRelation):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::elementsFromAttribute const):
* Source/WebCore/dom/CustomElementDefaultARIA.cpp:
(WebCore::CustomElementDefaultARIA::elementsForAttribute const):
(WebCore::CustomElementDefaultARIA::setElementsForAttribute):
* Source/WebCore/dom/CustomElementDefaultARIA.h:

Canonical link: https://commits.webkit.org/307437@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to