Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 218be3a71acaef145b63cab6e91c129a0994aa38
https://github.com/WebKit/WebKit/commit/218be3a71acaef145b63cab6e91c129a0994aa38
Author: Wenson Hsieh <[email protected]>
Date: 2026-02-13 (Fri, 13 Feb 2026)
Changed paths:
M
LayoutTests/fast/text-extraction/debug-text-extraction-form-controls-2-expected.txt
M
LayoutTests/fast/text-extraction/debug-text-extraction-form-controls-2.html
M Source/WebCore/page/text-extraction/TextExtraction.cpp
Log Message:
-----------
[AutoFill Debugging] Continue refining the `includeOffscreenPasswordFields`
heuristic
https://bugs.webkit.org/show_bug.cgi?id=307824
rdar://170331111
Reviewed by Aditya Keerthi.
Continue adjusting the `includeOffscreenPasswordFields` text extraction
heuristic, by:
- Making the minimum height slightly shorter.
- Putting the form controls inside a fixed-position banner.
*
LayoutTests/fast/text-extraction/debug-text-extraction-form-controls-2-expected.txt:
* LayoutTests/fast/text-extraction/debug-text-extraction-form-controls-2.html:
* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::findLargeContainerAboveNode):
`wasFixed` is set for any renderer inside a fixed-position element; this causes
us to extract only
the password field, in the case where it's inside a fixed element. Correct this
by instead checking
whether the current renderer itself is viewport-constrained (fixed or sticky).
(WebCore::TextExtraction::findContainerNodeForDataDetectorResults):
(WebCore::TextExtraction::extractItem):
Canonical link: https://commits.webkit.org/307506@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
