Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d498a35a268343ed3473b6b510f397a509c22daa
https://github.com/WebKit/WebKit/commit/d498a35a268343ed3473b6b510f397a509c22daa
Author: Tyler Wilcock <[email protected]>
Date: 2026-02-14 (Sat, 14 Feb 2026)
Changed paths:
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXID.h
M Source/WebCore/accessibility/AXTextMarker.cpp
M Source/WebCore/accessibility/AXTextMarker.h
M Source/WebCore/accessibility/AXTreeStore.h
M Source/WebCore/accessibility/AXTreeStoreInlines.h
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityObjectInlines.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
M Source/WebKit/Shared/WTFArgumentCoders.serialization.in
Log Message:
-----------
AX: Add AXTreeID type for type-safe tree identification
https://bugs.webkit.org/show_bug.cgi?id=307311
rdar://169944533
Reviewed by Joshua Hoffman.
Previously, tree IDs and object IDs both used the AXID type, which meant
the compiler couldn't catch mistakes where an objectID was passed to a
function expecting a treeID.
This patch introduces a separate AXTreeID type (using ObjectIdentifier
with a distinct tag type) to provide compile-time safety when working
with tree identifiers.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXID.h:
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarkerRange::AXTextMarkerRange):
* Source/WebCore/accessibility/AXTextMarker.h:
(WebCore::TextMarkerData::TextMarkerData):
(WebCore::TextMarkerData::axTreeID const):
(WebCore::AXTextMarker::AXTextMarker):
(WebCore::AXTextMarker::treeID const):
(WebCore::AXTextMarkerRange::AXTextMarkerRange):
* Source/WebCore/accessibility/AXTreeStore.h:
(WebCore::AXTreeStore::treeID const):
(WebCore::AXTreeStore::AXTreeStore):
(WebCore::AXTreeStore<T>::generateNewID):
* Source/WebCore/accessibility/AXTreeStoreInlines.h:
(WebCore::AXTreeStore<T>::set):
(WebCore::AXTreeStore<T>::add):
(WebCore::AXTreeStore<T>::remove):
(WebCore::AXTreeStore<T>::contains):
(WebCore::AXTreeStore<T>::axObjectCacheForID):
(WebCore::AXTreeStore<T>::isolatedTreeForID):
(WebCore::AXTreeStore<T>::liveTreeMap):
(WebCore::AXTreeStore<T>::isolatedTreeMap):
(WebCore::axTreeForID):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityObjectInlines.h:
(WebCore::AccessibilityObject::treeID const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
(WebCore::AXIsolatedTree::treeID const):
Canonical link: https://commits.webkit.org/307610@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
