Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 29051344fe966ddab5d9864f0d96e7ed998044a0
https://github.com/WebKit/WebKit/commit/29051344fe966ddab5d9864f0d96e7ed998044a0
Author: Simon Fraser <[email protected]>
Date: 2026-02-17 (Tue, 17 Feb 2026)
Changed paths:
M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
M Source/WebCore/page/scrolling/ScrollingCoordinator.h
M
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Log Message:
-----------
[iOS] Have WebPage::updateVisibleContentRects() funnel through
applyScrollUpdate()
https://bugs.webkit.org/show_bug.cgi?id=308097
rdar://170597603
Reviewed by Dan Glastonbury.
It's cleaner to make `reconcileScrollingState()` internal to
AsyncScrollingCoordinator, and
have `applyScrollUpdate()` as the entry-point to updating scrolling state for
messages coming
from the UI process. `WebPage::updateVisibleContentRects()` now creates a
`ScrollUpdate` for
the root scroller, and calls `applyScrollUpdate()`.
Change `AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll()` to
take
`ScrollUpdate&&` so we can just pass one through, but we have to pass
`ViewportRectStability`
along now too.
No behavior change.
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::synchronizeStateFromScrollingTree):
(WebCore::AsyncScrollingCoordinator::applyPendingScrollUpdates):
(WebCore::AsyncScrollingCoordinator::applyScrollUpdate):
(WebCore::AsyncScrollingCoordinator::applyScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h:
* Source/WebCore/page/scrolling/ScrollingCoordinator.h: Use an R-value
reference.
(WebCore::ScrollingCoordinator::applyScrollUpdate):
(WebCore::ScrollingCoordinator::reconcileScrollingState): Deleted.
*
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::dump): Just rely on RequestedScrollData's own dumping.
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h:
*
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::scrollUpdateForNode):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):
Canonical link: https://commits.webkit.org/307744@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications