Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0ce1f258ce6ee5f6e845455b4b68de984c1a48d9
https://github.com/WebKit/WebKit/commit/0ce1f258ce6ee5f6e845455b4b68de984c1a48d9
Author: Antti Koivisto <[email protected]>
Date: 2026-02-19 (Thu, 19 Feb 2026)
Changed paths:
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderObjectDocument.h
M Source/WebCore/rendering/RenderObjectInlines.h
Log Message:
-----------
Nullptr crash accessing settings when tearing down render tree
https://bugs.webkit.org/show_bug.cgi?id=308214
rdar://117839253
Reviewed by Alan Baradlay.
There is crash when tearing down a page cache entry where we access
RenderObject::settings() from
RenderTreeBuilder::Inline::Inline() and hit a null WeakPtr accessing frame/page.
It is not clear how this happens so the fix is speculative.
* Source/WebCore/rendering/RenderObject.h:
Also make it const accessor.
* Source/WebCore/rendering/RenderObjectDocument.h:
(WebCore::RenderObject::settings const):
Fix by getting Settings via document.settings() which won't be null even if the
document is disconnected from the frame.
This is a faster more direct way to do it anyway.
* Source/WebCore/rendering/RenderObjectInlines.h:
(WebCore::RenderObject::settings const): Deleted.
Canonical link: https://commits.webkit.org/307833@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
