Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8cb5592cf41f088fb34c7c8b2e7ae4a03e17a050
https://github.com/WebKit/WebKit/commit/8cb5592cf41f088fb34c7c8b2e7ae4a03e17a050
Author: Fujii Hironori <[email protected]>
Date: 2026-02-19 (Thu, 19 Feb 2026)
Changed paths:
A LayoutTests/http/tests/cookies/set-http-only-cookie-expected.txt
A LayoutTests/http/tests/cookies/set-http-only-cookie.html
A
LayoutTests/platform/glib/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt
M Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
Log Message:
-----------
[Soup] NetworkStorageSession::domCookiesForHost shoudn't return httpOnly
cookies
https://bugs.webkit.org/show_bug.cgi?id=308204
Reviewed by Carlos Garcia Campos.
GTK and WPE ports were observing an assertion failure in WebCookieCache.cpp
while browsing some web sites.
> ASSERTION FAILED: !cookie.httpOnly
> ../../../Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp(57) : String
> WebKit::cookiesToString(const Vector<WebCore::Cookie> &)
httpOnly cookies shouldn't be included in DOM cookies. Changed
NetworkStorageSession::domCookiesForHost not to include httpOnly cookies.
After this change, http/tests/cookies/js-get-and-set-http-only-cookie.html
started to fail. However, it's the same result as Mac port. Copied
platform/mac/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt to
glib.
Test: http/tests/cookies/set-http-only-cookie.html
* LayoutTests/http/tests/cookies/set-http-only-cookie-expected.txt: Added.
* LayoutTests/http/tests/cookies/set-http-only-cookie.html: Added.
*
LayoutTests/platform/glib/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt:
Added.
* Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::domCookiesForHost):
Canonical link: https://commits.webkit.org/307889@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
