Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4f9f29fa8bbfd43ef01a66205b59b6e1dd6caad6
https://github.com/WebKit/WebKit/commit/4f9f29fa8bbfd43ef01a66205b59b6e1dd6caad6
Author: Megan Gardner <[email protected]>
Date: 2026-02-20 (Fri, 20 Feb 2026)
Changed paths:
M Source/WebCore/page/ChromeClient.h
M Source/WebCore/page/FocusController.cpp
M Source/WebCore/page/FocusController.h
M Source/WebCore/page/Frame.cpp
M Source/WebCore/page/Frame.h
M Source/WebCore/page/RemoteFrameClient.h
M Source/WebKit/UIProcess/WebFrameProxy.cpp
M Source/WebKit/UIProcess/WebFrameProxy.h
M Source/WebKit/UIProcess/WebFrameProxy.messages.in
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.h
M Source/WebKit/WebProcess/WebPage/WebFrame.messages.in
M Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm
Log Message:
-----------
Focus cannot advance from one remote frame to a sibling remote frame by
pressing 'tab'.
https://bugs.webkit.org/show_bug.cgi?id=307510
rdar://170108802
Reviewed by Ryosuke Niwa.
When we are trying to advance focus and reach the end of a frame
and don't find anything to focus, but we know we have a parent
frame, we need to continue searching in the scope of that parent
frame. I think there is more work to be done for frames that have
no focusable elements, but this is still forward progress on remote
frame focus.
Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::frameOwnerElementForFrameID const):
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusNavigationScope::owner const):
(WebCore::FocusController::findFocusableElementContinuingFromFrame):
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::findFocusableElementWithinScope):
* Source/WebCore/page/FocusController.h:
* Source/WebCore/page/Frame.cpp:
(WebCore::Frame::parent const):
* Source/WebCore/page/Frame.h:
* Source/WebCore/page/RemoteFrameClient.h:
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::findFocusableElementContinuingFromFrame):
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebFrameProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::frameOwnerElementForFrameID const):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::findFocusableElementContinuingFromFrame):
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h:
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::findFocusableElementContinuingFromFrame):
* Source/WebKit/WebProcess/WebPage/WebFrame.h:
* Source/WebKit/WebProcess/WebPage/WebFrame.messages.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm:
(TestWebKitAPI::MultipleFrames)):
Canonical link: https://commits.webkit.org/307928@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
