Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 170ff2c744dd6f63b2847ba4bd9331c110b08d86
https://github.com/WebKit/WebKit/commit/170ff2c744dd6f63b2847ba4bd9331c110b08d86
Author: Ryosuke Niwa <[email protected]>
Date: 2026-02-21 (Sat, 21 Feb 2026)
Changed paths:
M
Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.h
M Source/WebCore/Modules/WebGPU/GPUCommandBuffer.h
M
Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUXRBindingImpl.h
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUXRSubImageImpl.h
M Source/WebCore/Modules/applepay-ams-ui/ApplePayAMSUIPaymentHandler.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySession.h
M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeys.h
M Source/WebCore/Modules/geolocation/Geolocation.h
M Source/WebCore/Modules/identity/CredentialRequestCoordinator.h
M Source/WebCore/Modules/indexeddb/IDBDatabase.h
M Source/WebCore/Modules/indexeddb/server/IndexValueStore.h
M Source/WebCore/Modules/indexeddb/server/ServerOpenDBRequest.h
M Source/WebCore/Modules/mediasession/MediaMetadata.h
M Source/WebCore/Modules/mediasession/MediaSession.h
M Source/WebCore/Modules/mediastream/MediaTrackCapabilities.cpp
M Source/WebCore/Modules/mediastream/RTCIceCandidate.h
M Source/WebCore/Modules/mediastream/RTCRtpSender.h
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp
M Source/WebCore/Modules/model-element/ModelPlayerAnimationState.h
M Source/WebCore/Modules/paymentrequest/PaymentRequest.h
M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h
M Source/WebCore/Modules/streams/ReadableStream.h
M Source/WebCore/Modules/streams/StreamTeeUtilities.cpp
M Source/WebCore/Modules/url-pattern/URLPattern.cpp
M Source/WebCore/Modules/url-pattern/URLPatternConstructorStringParser.cpp
M Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp
M Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h
M Source/WebCore/Modules/webaudio/AudioContext.h
M Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp
M Source/WebCore/Modules/webaudio/AudioParamTimeline.h
M Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.h
M Source/WebCore/Modules/webaudio/AudioWorkletThread.h
M Source/WebCore/Modules/webaudio/BaseAudioContext.h
M Source/WebCore/Modules/webaudio/BiquadDSPKernel.cpp
M Source/WebCore/Modules/webaudio/OscillatorNode.cpp
M Source/WebCore/Modules/webaudio/OscillatorNode.h
M Source/WebCore/Modules/webaudio/PannerNode.cpp
M Source/WebCore/Modules/webaudio/PeriodicWave.h
M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.h
M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.h
M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.h
M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h
M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrameAlgorithms.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrameAlgorithms.h
M
Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.h
M Source/WebCore/Modules/websockets/WebSocketDeflateFramer.h
M Source/WebCore/Modules/websockets/WebSocketHandshake.h
M Source/WebCore/SaferCPPExpectations/NoDeleteCheckerExpectations
M Source/WebCore/css/CSSCounterStyleDescriptors.h
M Source/WebCore/css/CSSFontFace.cpp
M Source/WebCore/css/CSSFontFace.h
M Source/WebCore/css/CSSImageSetOptionValue.h
M Source/WebCore/css/CSSPrimitiveValue.h
M Source/WebCore/css/CSSStyleSheet.h
M Source/WebCore/css/DOMMatrixReadOnly.cpp
M Source/WebCore/css/PropertySetCSSDescriptors.h
M Source/WebCore/css/SelectorChecker.h
M Source/WebCore/css/ShorthandSerializer.cpp
M Source/WebCore/css/StyleRule.h
M Source/WebCore/css/StyleSheetContents.h
M Source/WebCore/css/query/ContainerQueryFeatures.cpp
M Source/WebCore/css/typedom/CSSKeywordValue.h
M Source/WebCore/css/typedom/color/CSSOMColorValue.h
M Source/WebCore/css/typedom/transform/CSSMatrixComponent.h
M Source/WebCore/css/typedom/transform/CSSRotate.h
M Source/WebCore/css/typedom/transform/CSSSkew.h
M Source/WebCore/css/typedom/transform/CSSSkewX.h
M Source/WebCore/css/values/color/CSSColorMix.cpp
M Source/WebCore/dom/ContainerNode.h
M Source/WebCore/dom/Element.h
M Source/WebCore/dom/ElementInternals.h
M Source/WebCore/page/Chrome.cpp
M Source/WebCore/page/DOMWindow.h
M Source/WebCore/page/DebugPageOverlays.cpp
M Source/WebCore/page/DragController.cpp
M Source/WebCore/page/ElementTargetingController.cpp
M Source/WebCore/page/ElementTargetingController.h
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/EventHandler.h
M Source/WebCore/page/FocusController.cpp
M Source/WebCore/page/Frame.cpp
M Source/WebCore/page/FrameTree.cpp
M Source/WebCore/page/LargestContentfulPaint.h
M Source/WebCore/page/LargestContentfulPaintData.h
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalDOMWindow.h
M Source/WebCore/page/LocalFrameView.h
M Source/WebCore/page/LocalFrameViewLayoutContext.h
M Source/WebCore/page/Navigation.h
M Source/WebCore/page/Navigator.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/page/Performance.h
M Source/WebCore/page/RemoteDOMWindow.h
M Source/WebCore/page/ResizeObservation.h
M Source/WebCore/page/ScreenOrientation.h
M Source/WebCore/page/ViewportConfiguration.cpp
M Source/WebCore/page/ViewportConfiguration.h
M Source/WebCore/page/VisualViewport.h
M Source/WebCore/page/WheelEventDeltaFilter.cpp
M Source/WebCore/page/csp/ContentSecurityPolicy.h
M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.h
M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
M Source/WebCore/page/scrolling/ScrollAnchoringController.h
M Source/WebCore/page/scrolling/ScrollLatchingController.cpp
M Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp
M Source/WebCore/page/scrolling/ScrollingConstraints.h
M Source/WebCore/page/scrolling/ScrollingStateTree.h
M Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h
M Source/WebCore/page/scrolling/cocoa/ScrollingStateNode.mm
M Source/WebCore/page/text-extraction/TextExtraction.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderMarquee.h
Log Message:
-----------
Remove NODELETE from WebCore functions that emit warning in NoDeleteChecker
https://bugs.webkit.org/show_bug.cgi?id=308338
Reviewed by Wenson Hsieh.
Removed NODELETE annotations from WebCore functions for which NoDeleteChecker
emits warnings
since we fixed the false negatives by rolling out a newer version of clang in
307871@main.
Some of these functions look "trivial". We should investigate & fix trivial
function analysis
but that's for another time.
No new tests since there should be no behavioral changes.
* Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.h:
* Source/WebCore/Modules/WebGPU/GPUCommandBuffer.h:
*
Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp:
(WebCore::WebGPU::compare):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUXRBindingImpl.h:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUXRSubImageImpl.h:
* Source/WebCore/Modules/applepay-ams-ui/ApplePayAMSUIPaymentHandler.h:
* Source/WebCore/Modules/encryptedmedia/MediaKeySession.h:
* Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeys.h:
* Source/WebCore/Modules/geolocation/Geolocation.h:
* Source/WebCore/Modules/identity/CredentialRequestCoordinator.h:
* Source/WebCore/Modules/indexeddb/IDBDatabase.h:
* Source/WebCore/Modules/indexeddb/server/IndexValueStore.h:
* Source/WebCore/Modules/indexeddb/server/ServerOpenDBRequest.h:
* Source/WebCore/Modules/mediasession/MediaMetadata.h:
* Source/WebCore/Modules/mediasession/MediaSession.h:
* Source/WebCore/Modules/mediastream/MediaTrackCapabilities.cpp:
(WebCore::capabilityDoubleRange):
* Source/WebCore/Modules/mediastream/RTCIceCandidate.h:
* Source/WebCore/Modules/mediastream/RTCRtpSender.h:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:
(WebCore::fromWebRTCBitRatePriority):
* Source/WebCore/Modules/model-element/ModelPlayerAnimationState.h:
* Source/WebCore/Modules/paymentrequest/PaymentRequest.h:
* Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h:
* Source/WebCore/Modules/streams/ReadableStream.h:
* Source/WebCore/Modules/streams/StreamTeeUtilities.cpp:
* Source/WebCore/Modules/url-pattern/URLPattern.cpp:
(WebCore::matchHelperAssignInputsFromInit):
* Source/WebCore/Modules/url-pattern/URLPatternConstructorStringParser.cpp:
(WebCore::setInitComponentFromState):
* Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::computeSampleUsingLinearInterpolation):
* Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h:
* Source/WebCore/Modules/webaudio/AudioContext.h:
* Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::fillWithValue):
(WebCore::hasSetTargetConverged):
(WebCore::isValidNumber):
* Source/WebCore/Modules/webaudio/AudioParamTimeline.h:
* Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.h:
* Source/WebCore/Modules/webaudio/AudioWorkletThread.h:
* Source/WebCore/Modules/webaudio/BaseAudioContext.h:
* Source/WebCore/Modules/webaudio/BiquadDSPKernel.cpp:
(WebCore::hasConstantValue):
* Source/WebCore/Modules/webaudio/OscillatorNode.cpp:
(WebCore::detuneToFrequencyMultiplier):
(WebCore::doInterpolation):
* Source/WebCore/Modules/webaudio/OscillatorNode.h:
* Source/WebCore/Modules/webaudio/PannerNode.cpp:
(WebCore::fixNANs):
* Source/WebCore/Modules/webaudio/PeriodicWave.h:
* Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.h:
* Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.h:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.h:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrameAlgorithms.cpp:
(WebCore::isMultiple):
(WebCore::isNegativeOrNonFinite):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrameAlgorithms.h:
* Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
* Source/WebCore/Modules/websockets/WebSocketDeflateFramer.h:
* Source/WebCore/Modules/websockets/WebSocketHandshake.h:
* Source/WebCore/SaferCPPExpectations/NoDeleteCheckerExpectations:
* Source/WebCore/css/CSSCounterStyleDescriptors.h:
* Source/WebCore/css/CSSFontFace.cpp:
(WebCore::visibility):
* Source/WebCore/css/CSSFontFace.h:
* Source/WebCore/css/CSSImageSetOptionValue.h:
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/CSSStyleSheet.h:
* Source/WebCore/css/DOMMatrixReadOnly.cpp:
(WebCore::sameValueZero):
* Source/WebCore/css/PropertySetCSSDescriptors.h:
* Source/WebCore/css/SelectorChecker.h:
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::fontWidthKeyword):
* Source/WebCore/css/StyleRule.h:
* Source/WebCore/css/StyleSheetContents.h:
* Source/WebCore/css/query/ContainerQueryFeatures.cpp:
(WebCore::CQ::unscaledSizeForPrincipleBox):
* Source/WebCore/css/typedom/CSSKeywordValue.h:
* Source/WebCore/css/typedom/color/CSSOMColorValue.h:
* Source/WebCore/css/typedom/transform/CSSMatrixComponent.h:
* Source/WebCore/css/typedom/transform/CSSRotate.h:
* Source/WebCore/css/typedom/transform/CSSSkew.h:
* Source/WebCore/css/typedom/transform/CSSSkewX.h:
* Source/WebCore/css/values/color/CSSColorMix.cpp:
(WebCore::CSS::ColorMixSerializationDetails::sumTo100Percent):
(WebCore::CSS::ColorMixSerializationDetails::subtractFrom100Percent):
* Source/WebCore/dom/ContainerNode.h:
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/ElementInternals.h:
* Source/WebCore/history/CachedFrame.h:
* Source/WebCore/history/HistoryItem.h:
* Source/WebCore/loader/CookieJar.cpp:
(WebCore::shouldRelaxThirdPartyCookieBlocking):
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::setPrinting):
(WebCore::EmptyFrameLoaderClient::createFrame):
(WebCore::EmptyFrameLoaderClient::createPlugin):
(WebCore::EmptyFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebCore::EmptyFrameLoaderClient::isolatedTree const):
(WebCore::EmptyFrameLoaderClient::createHistoryItemTree const):
* Source/WebCore/loader/EmptyClients.h:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::allAncestorsAreComplete const):
(WebCore::shouldAskForNavigationConfirmation):
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/loader/HistoryController.cpp:
(WebCore::canRecordHistoryForFrame):
* Source/WebCore/loader/HistoryController.h:
* Source/WebCore/loader/ImageLoader.h:
* Source/WebCore/loader/LinkHeader.h:
* Source/WebCore/loader/ResourceLoader.h:
* Source/WebCore/loader/cache/CachedResourceRequest.h:
* Source/WebCore/loader/cache/MemoryCache.h:
* Source/WebCore/page/Chrome.cpp:
(WebCore::Chrome::runModal):
* Source/WebCore/page/DOMWindow.h:
* Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::MouseWheelRegionOverlay::updateRegion):
* Source/WebCore/page/DragController.cpp:
(WebCore::enclosingAttachmentElement):
* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::linearlyInterpolatedViewportRatio):
(WebCore::maximumAreaRatioForAbsolutelyPositionedContent):
(WebCore::maximumAreaRatioForInFlowContent):
(WebCore::maximumAreaRatioForNearbyTargets):
(WebCore::minimumAreaRatioForInFlowContent):
(WebCore::maximumAreaRatioForTrackingAdjustmentAreas):
(WebCore::shortestSelector):
* Source/WebCore/page/ElementTargetingController.h:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::shouldRefetchEventTarget):
(WebCore::contentFrameForNode):
* Source/WebCore/page/EventHandler.h:
* Source/WebCore/page/FocusController.cpp:
(WebCore::invokerForOpenPopover):
(WebCore::FocusNavigationScope::owner const):
* Source/WebCore/page/Frame.cpp:
(WebCore::Frame::ownerRenderer const):
* Source/WebCore/page/FrameTree.cpp:
(WebCore::FrameTree::setSpecifiedName):
(WebCore::FrameTree::clearName):
* Source/WebCore/page/LargestContentfulPaint.h:
* Source/WebCore/page/LargestContentfulPaintData.h:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::allowsBeforeUnloadListeners):
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/LocalFrameViewLayoutContext.h:
* Source/WebCore/page/Navigation.h:
* Source/WebCore/page/Navigator.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setBroadcastChannelRegistry):
(WebCore::Page::setInitialScaleIgnoringContentSize):
(WebCore::Page::setHorizontalScrollElasticity):
* Source/WebCore/page/Page.h:
* Source/WebCore/page/Performance.h:
* Source/WebCore/page/RemoteDOMWindow.h:
* Source/WebCore/page/ResizeObservation.h:
* Source/WebCore/page/ScreenOrientation.h:
* Source/WebCore/page/ViewportConfiguration.cpp:
(WebCore::viewportArgumentValueIsValid):
(WebCore::booleanViewportArgumentIsSet):
* Source/WebCore/page/ViewportConfiguration.h:
* Source/WebCore/page/VisualViewport.h:
* Source/WebCore/page/WheelEventDeltaFilter.cpp:
(WebCore::deltaIsPredominantlyVertical):
* Source/WebCore/page/csp/ContentSecurityPolicy.h:
* Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.h:
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h:
* Source/WebCore/page/scrolling/ScrollAnchoringController.h:
* Source/WebCore/page/scrolling/ScrollLatchingController.cpp:
(WebCore::deltaIsPredominantlyVertical):
* Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp:
(WebCore::convertOffsetUnit):
* Source/WebCore/page/scrolling/ScrollingConstraints.h:
* Source/WebCore/page/scrolling/ScrollingStateTree.h:
* Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:
* Source/WebCore/page/scrolling/cocoa/ScrollingStateNode.mm:
(WebCore::LayerRepresentation::makePlatformLayerTypeless):
* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::hasEnclosingAutoFilledInput):
(WebCore::TextExtraction::shouldTreatAsPasswordField):
(WebCore::TextExtraction::extractItemData):
(WebCore::TextExtraction::reducePrecision):
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderMarquee.h:
Canonical link: https://commits.webkit.org/307968@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
