Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c9e58f72c198274e320ab17896ec02146e125149
https://github.com/WebKit/WebKit/commit/c9e58f72c198274e320ab17896ec02146e125149
Author: David Kilzer <[email protected]>
Date: 2026-02-22 (Sun, 22 Feb 2026)
Changed paths:
A
LayoutTests/http/tests/media/track-in-band-hls-metadata-removecue-non-datacue-crash-expected.txt
A
LayoutTests/http/tests/media/track-in-band-hls-metadata-removecue-non-datacue-crash.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/html/track/InbandDataTextTrack.cpp
Log Message:
-----------
[WebVTT] InbandDataTextTrack::removeCue crashes when removing non-DataCue cues
<https://bugs.webkit.org/show_bug.cgi?id=308414>
<rdar://122375096>
Reviewed by Eric Carlson.
Guard the DataCue-specific cleanup in `InbandDataTextTrack::removeCue()`
with `is<DataCue>(cue)` and fall through to the base class for all cue
types.
The HTML spec places no restrictions on which cue types can be added to
which track types.
Test:
http/tests/media/track-in-band-hls-metadata-removecue-non-datacue-crash.html
*
LayoutTests/http/tests/media/track-in-band-hls-metadata-removecue-non-datacue-crash-expected.txt:
Add.
*
LayoutTests/http/tests/media/track-in-band-hls-metadata-removecue-non-datacue-crash.html:
Add.
* LayoutTests/platform/glib/TestExpectations:
- Skip this HLS test on GLib platform.
* Source/WebCore/html/track/InbandDataTextTrack.cpp:
(WebCore::InbandDataTextTrack::removeCue):
Canonical link: https://commits.webkit.org/308019@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
