Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 23e98bacf9cc6b54ccf6e70d2c96c5a52bbe3dd2
https://github.com/WebKit/WebKit/commit/23e98bacf9cc6b54ccf6e70d2c96c5a52bbe3dd2
Author: Ryosuke Niwa <[email protected]>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M Tools/Scripts/update-safer-cpp-expectations
Log Message:
-----------
Make update-safer-cpp-expectations work well with expectations with a
platform specifier
https://bugs.webkit.org/show_bug.cgi?id=308289
Reviewed by Brianna Fan.
This PR fixes a few bugs in update-safer-cpp-expectations to make it work
better with
a platform specifier in the safer C++ expectations.
update_expectations_from_file is updated to support adding / removing platform
specific
expectations by re-using modify_expectations_for_checker, which already
supports parsing
and sorting expectations instead of calling
modify_expectations_for_checker_from_file,
which has been deleted.
update_expectations_from_file now parses the list of files and checker type
using the
for loop instead of delegating that work to
modify_expectations_for_checker_from_file.
Fixed a bug in modify_expectations_for_checker that it treated having
expectations for
both macOS and iOS as a conflict by simply removing the platform specifier. And
added
the missing code to add a new expectation entry in
modify_expectations_for_checker.
* Tools/Scripts/update-safer-cpp-expectations:
(modify_expectations_for_checker_from_file): Deleted.
(update_expectations_from_file): Updated to use
modify_expectations_for_checker. Now
parses the input file's content and calls modify_expectations_for_checker with
it.
(modify_expectations_for_checker): Now consolidates two entries for the same
file in
macOS and iOS and fixed the bug that it wasn't adding new entries.
(main):
Canonical link: https://commits.webkit.org/308059@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
