Title: [114272] trunk/Source/WebCore
- Revision
- 114272
- Author
- ca...@chromium.org
- Date
- 2012-04-16 10:25:26 -0700 (Mon, 16 Apr 2012)
Log Message
Web Inspector: timeline. Range selection works incorrect with right click
https://bugs.webkit.org/show_bug.cgi?id=83870
Reviewed by Pavel Feldman.
- only start window dragging upon mousedown with left button (right will cause a context menu and we won't see mouseup)
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewWindow.prototype._dragWindow):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114271 => 114272)
--- trunk/Source/WebCore/ChangeLog 2012-04-16 17:23:18 UTC (rev 114271)
+++ trunk/Source/WebCore/ChangeLog 2012-04-16 17:25:26 UTC (rev 114272)
@@ -1,3 +1,34 @@
+2012-04-16 Andrey Kosyakov <ca...@chromium.org>
+
+ Web Inspector: timeline. Range selection works incorrect with right click
+ https://bugs.webkit.org/show_bug.cgi?id=83870
+
+ Reviewed by Pavel Feldman.
+
+ - only start window dragging upon mousedown with left button (right will cause a context menu and we won't see mouseup)
+
+ * inspector/front-end/TimelineOverviewPane.js:
+ (WebInspector.TimelineOverviewWindow.prototype._dragWindow):
+
+2012-04-16 Andrey Kosyakov <ca...@chromium.org>
+
+ Web Inspector: touch pad is pain to use in lower pane of Timeline panel due two two-axis scrolling
+ https://bugs.webkit.org/show_bug.cgi?id=83946
+
+ Reviewed by Pavel Feldman.
+
+ Remove delegation of mousewheel events from lower timeline pane to the timeline overview. This disables
+ support for moving overview window with horizontal swype over lower timeline pane, thus removing
+ an irritating situation when we try to both change overview window and scroll lower timeline pane
+ upon a single touchpad gesture. Those willing to move timeline window now would need to position
+ mouse over overview.
+
+ * inspector/front-end/TimelineOverviewPane.js:
+ (WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
+ (WebInspector.TimelineOverviewWindow.prototype._zoom):
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel):
+
2012-04-16 Yury Semikhatsky <yu...@chromium.org>
Web Inspector: rename heap profiler files and classes DetailedHeapshot* ->HeapSnapshot*
Modified: trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js (114271 => 114272)
--- trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js 2012-04-16 17:23:18 UTC (rev 114271)
+++ trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js 2012-04-16 17:25:26 UTC (rev 114272)
@@ -464,6 +464,9 @@
_dragWindow: function(event)
{
+ // Only drag upon left button. Right will likely cause a context menu.
+ if (event.button)
+ return;
var node = event.target;
while (node) {
if (node.hasStyleClass("resources-dividers-label-bar")) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
