Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1094f9ce271a8821e03ebacc7a761204a0046138
https://github.com/WebKit/WebKit/commit/1094f9ce271a8821e03ebacc7a761204a0046138
Author: Sammy Gill <[email protected]>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h
Log Message:
-----------
[Grid] Remove RenderGrid::m_baselineItemsCached
https://bugs.webkit.org/show_bug.cgi?id=308344
rdar://170837971
Reviewed by Vitor Roriz.
This member variable was added in 206626@main as part of the initial
implementation of baseline alignment for grid items. The primary use case
of this field seems to be sharing a list of baseline aligned grid items
between RenderGrid::layoutBlock and RenderGrid::computeIntriniscLogicalWidths.
There does not appear to be any additional information with empirical
perf benefits in the commit message, bugzilla, or comments. Running this
patch through A/B testing also seems to show that it is neutral on both
PLT and Speedometer.
Since there is no clear perf benefit in terms of competitive benchmarks
or otherwise, I am opting to remove this field entirely in order to make
it easier to rework other parts of the code by removing a dependency
between these two paths. The goal is for GridTrackSizingAlgorithm to
move off of RenderGrid eventually and live on the stack instead but we
cannot do this currently sine computeIntrinsicLogicalWidths expects to
be able to access the GridTrackSizingAlgorithm that lives on the
renderer to get access to these lists of items. Instead, we can just
compute this list whenever we need it which we already seem to do in
certain cases when this flag is false.
Canonical link: https://commits.webkit.org/308078@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
