Title: [114275] trunk/Source/WebKit/chromium
- Revision
- 114275
- Author
- [email protected]
- Date
- 2012-04-16 10:43:23 -0700 (Mon, 16 Apr 2012)
Log Message
Fix bug in WebPluginContainer::isRectTopmost() which gave the incorrect result for a scrolled window.
https://bugs.webkit.org/show_bug.cgi?id=80606
Patch by Raymes Khoury <[email protected]> on 2012-04-16
Reviewed by Darin Fisher.
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (114274 => 114275)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-16 17:41:52 UTC (rev 114274)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-16 17:43:23 UTC (rev 114275)
@@ -1,3 +1,13 @@
+2012-04-16 Raymes Khoury <[email protected]>
+
+ Fix bug in WebPluginContainer::isRectTopmost() which gave the incorrect result for a scrolled window.
+ https://bugs.webkit.org/show_bug.cgi?id=80606
+
+ Reviewed by Darin Fisher.
+
+ * src/WebPluginContainerImpl.cpp:
+ (WebKit::WebPluginContainerImpl::isRectTopmost):
+
2012-04-15 Keishi Hattori <[email protected]>
Introduce MenuItemID to autofill popup
Modified: trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (114274 => 114275)
--- trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-04-16 17:41:52 UTC (rev 114274)
+++ trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-04-16 17:43:23 UTC (rev 114275)
@@ -453,10 +453,10 @@
// hitTestResultAtPoint() takes a padding rectangle.
// FIXME: We'll be off by 1 when the width or height is even.
- IntRect windowRect = convertToContainingWindow(static_cast<IntRect>(rect));
- LayoutPoint center = windowRect.center();
+ IntRect documentRect(x() + rect.x, y() + rect.y, rect.width, rect.height);
+ LayoutPoint center = documentRect.center();
// Make the rect we're checking (the point surrounded by padding rects) contained inside the requested rect. (Note that -1/2 is 0.)
- LayoutSize padding((windowRect.width() - 1) / 2, (windowRect.height() - 1) / 2);
+ LayoutSize padding((documentRect.width() - 1) / 2, (documentRect.height() - 1) / 2);
HitTestResult result =
page->mainFrame()->eventHandler()->hitTestResultAtPoint(center, false, false, DontHitTestScrollbars, HitTestRequest::ReadOnly | HitTestRequest::Active, padding);
const HitTestResult::NodeSet& nodes = result.rectBasedTestResult();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
