Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 877420ffe1a6083f7afea862e9c343e9762fcc76
https://github.com/WebKit/WebKit/commit/877420ffe1a6083f7afea862e9c343e9762fcc76
Author: Sihui Liu <[email protected]>
Date: 2026-02-25 (Wed, 25 Feb 2026)
Changed paths:
M LayoutTests/platform/ios-site-isolation/TestExpectations
M LayoutTests/platform/mac-site-isolation/TestExpectations
M LayoutTests/storage/indexeddb/resources/shared.js
Log Message:
-----------
[Site Isolation] Fix storage/indexeddb tests
https://bugs.webkit.org/show_bug.cgi?id=308614
rdar://171137311
Reviewed by Per Arne Vollan.
TestRunner::notifyDone() dumps result asynchronously under Site Isolation,
which means JS code runs after notifyDone()
could impact the test output. For the failing IndexedDB tests, the imported
shared script automatically registers
callbacks for error and blocked events, and those events might be fired after
notifyDone() is invoked, leading to more
text in the test output. To fix this, make sure the callbacks verify the test
is not marked finished yet (i.e.
finishJSTest() or notifyDone() is not invoked yet) before proceeding. This
fixes 7 tests.
* LayoutTests/platform/ios-site-isolation/TestExpectations:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/storage/indexeddb/resources/shared.js:
(unexpectedErrorCallback):
(unexpectedBlockedCallback):
Canonical link: https://commits.webkit.org/308218@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
