Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9602fd73f1e55c18f9f1b69c060b9625082a9ce1
https://github.com/WebKit/WebKit/commit/9602fd73f1e55c18f9f1b69c060b9625082a9ce1
Author: Said Abou-Hallawa <[email protected]>
Date: 2026-02-26 (Thu, 26 Feb 2026)
Changed paths:
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp
M Source/WebCore/style/Styleable.cpp
Log Message:
-----------
[appearance: base] Optimize ::picker-icon renderer look ups
https://bugs.webkit.org/show_bug.cgi?id=308229
rdar://170737149
Reviewed by Antti Koivisto.
Store a WeakPtr to the :picker-icon renderer in the <select> element renderer.
Use this pointer while navigating up to ensure we return the ancestor <select>
element correctly.
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::pickerIconRenderer const):
(WebCore::RenderElement::setPickerIconRenderer):
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderObject.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp:
(WebCore::RenderTreeBuilder::FormControls::updatePseudoElement):
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::fromRenderer):
Canonical link: https://commits.webkit.org/308291@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
