[webkit-changes] [WebKit/WebKit] 72ca3c: Use an enum class for NodeType

Fri, 27 Feb 2026 03:16:16 -0800 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72ca3c92c833fef50a4efc4c820da90a69737f27
      
https://github.com/WebKit/WebKit/commit/72ca3c92c833fef50a4efc4c820da90a69737f27
  Author: Anne van Kesteren <[email protected]>
  Date:   2026-02-27 (Fri, 27 Feb 2026)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/JSDOMWrapper.h
    M Source/WebCore/bindings/js/JSNodeCustom.cpp
    M Source/WebCore/bindings/scripts/CodeGenerator.pm
    M Source/WebCore/bindings/scripts/IDLAttributes.json
    M Source/WebCore/css/CSSStyleSheet.cpp
    M Source/WebCore/dom/Attr.cpp
    M Source/WebCore/dom/Attr.h
    M Source/WebCore/dom/CDATASection.cpp
    M Source/WebCore/dom/CDATASection.h
    M Source/WebCore/dom/Comment.cpp
    M Source/WebCore/dom/Comment.h
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/DocumentFragment.cpp
    M Source/WebCore/dom/DocumentType.cpp
    M Source/WebCore/dom/DocumentType.h
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/dom/Node.h
    M Source/WebCore/dom/Node.idl
    R Source/WebCore/dom/NodeConstants.h
    A Source/WebCore/dom/NodeType.h
    M Source/WebCore/dom/ProcessingInstruction.cpp
    M Source/WebCore/dom/ProcessingInstruction.h
    M Source/WebCore/dom/Range.cpp
    M Source/WebCore/dom/StaticRange.cpp
    M Source/WebCore/dom/Text.cpp
    M Source/WebCore/dom/Text.h
    M Source/WebCore/dom/Traversal.h
    M Source/WebCore/editing/MarkupAccumulator.cpp
    M Source/WebCore/html/track/TextTrackCue.cpp
    M Source/WebCore/inspector/DOMPatchSupport.cpp
    M Source/WebCore/inspector/InspectorNodeFinder.cpp
    M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
    M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
    M Source/WebCore/rendering/RenderTreeAsText.cpp
    M Source/WebCore/xml/XPathStep.cpp
    M Source/WebCore/xml/XPathUtil.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/DOM/WebKitDOMPrivate.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeGtk.cpp
    M 
Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMPrivateGtk.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm
    M Source/WebKitLegacy/mac/DOM/DOM.mm
    M Source/WebKitLegacy/mac/DOM/DOMNode.mm
    M Source/WebKitLegacy/mac/DOM/WebDOMOperations.mm

  Log Message:
  -----------
  Use an enum class for NodeType
https://bugs.webkit.org/show_bug.cgi?id=308745
rdar://171332209

Reviewed by Ryosuke Niwa.

Also remove DeprecatedNodeType entirely as it's not used in the code.
We keep DocumentPosition as-is for now (with some slight binding tweaks
to allow for that) as making it an enum class would require a lot of
conversion due to all the bitwise operations. Might still be worth
doing, but probably best as a separate change.

Canonical link: https://commits.webkit.org/308331@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to