Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: db14f805f786480be3828341eefdc7823cea91de
https://github.com/WebKit/WebKit/commit/db14f805f786480be3828341eefdc7823cea91de
Author: Razvan Caliman <[email protected]>
Date: 2026-02-27 (Fri, 27 Feb 2026)
Changed paths:
M Source/WebInspectorUI/UserInterface/Base/Setting.js
M Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js
Log Message:
-----------
Web Inspector: Network: Follow-up for Bug 308310 Request / Response menu
ignores user’s previous setting
https://bugs.webkit.org/show_bug.cgi?id=308642
rdar://171168680
Reviewed by Devin Rousso.
Replace the singular "resource-content-view-identifier-for-mime-type" setting
with individual settings per mime type.
Remove `WI.ResourceClusterContentView.prototype.attached()` with its logic to
show
a prefered or default content view because
`WI.ResourceClusterContentView.prototype.restoreFromCookie()`,
which already handles this, is always called.
This view is always shown via the call chain
`WI.ContentViewContainer.showBackForwardEntryForIndex()` -> `_showEntry()`
which creates the view, attaches it, then calls `restoreFromCookie()` on it.
* Source/WebInspectorUI/UserInterface/Base/Setting.js:
(WI.Setting.prototype.save):
Drive-by: check for equality between primitives (string, number, boolean),
not just shallow equal objects, when determining if the new value and default
value
are identical in order to remove the entry from local storage.
* Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:
(WI.ResourceClusterContentView.prototype._showContentViewForIdentifier):
(WI.ResourceClusterContentView.prototype._pathComponentSelected):
(WI.ResourceClusterContentView.prototype._getPreferredContentViewIdentifier):
(WI.ResourceClusterContentView.prototype._getPreferredContentViewSetting):
(WI.ResourceClusterContentView.prototype._setPreferredContentViewIdentifier):
(WI.ResourceClusterContentView.prototype.async
_tryEnableCustomResponseContentViews):
(WI.ResourceClusterContentView):
(WI.ResourceClusterContentView.prototype.attached): Deleted.
(WI.ResourceClusterContentView.prototype.closed): Deleted.
(WI.ResourceClusterContentView.prototype._tryEnableCustomResponseContentViews):
Deleted.
Canonical link: https://commits.webkit.org/308344@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
