Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 726af0edf132d5a824778e3c96d650cb76e2a7ce
https://github.com/WebKit/WebKit/commit/726af0edf132d5a824778e3c96d650cb76e2a7ce
Author: Basuke Suzuki <[email protected]>
Date: 2026-02-27 (Fri, 27 Feb 2026)
Changed paths:
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
Log Message:
-----------
[Site Isolation] WebFrame::url() returns null in dispatchDidCommitLoad during
process swap.
https://bugs.webkit.org/show_bug.cgi?id=308679
rdar://169559232
Reviewed by Sihui Liu and Per Arne Vollan.
In dispatchDidCommitLoad, commitProvisionalFrame() is called after the
InjectedBundle and
sandbox extension callbacks. Before that call, m_coreFrame still points to a
RemoteFrame,
so WebFrame::url() fails the LocalFrame downcast and returns a null URL.
Move commitProvisionalFrame() to the top of dispatchDidCommitLoad so
m_coreFrame is updated
before any code that depends on it. This is safe for the non-Site-Isolation
path because
commitProvisionalFrame() is a no-op when there is no provisional frame.
No new tests are added because there's no the behavior change.
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::dispatchDidCommitLoad):
Canonical link: https://commits.webkit.org/308382@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
