Title: [114311] trunk/Source/WebCore
Revision
114311
Author
ander...@apple.com
Date
2012-04-16 15:50:33 -0700 (Mon, 16 Apr 2012)

Log Message

Crash when running some editing related tests
https://bugs.webkit.org/show_bug.cgi?id=84091

Reviewed by Andreas Kling.

Null check triggeringEvent.

* editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (114310 => 114311)


--- trunk/Source/WebCore/ChangeLog	2012-04-16 22:27:32 UTC (rev 114310)
+++ trunk/Source/WebCore/ChangeLog	2012-04-16 22:50:33 UTC (rev 114311)
@@ -1,3 +1,15 @@
+2012-04-16  Anders Carlsson  <ander...@apple.com>
+
+        Crash when running some editing related tests
+        https://bugs.webkit.org/show_bug.cgi?id=84091
+
+        Reviewed by Andreas Kling.
+
+        Null check triggeringEvent.
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::insertTextWithoutSendingTextEvent):
+
 2012-04-16  Simon Fraser  <simon.fra...@apple.com>
 
         Rename to updateZOrderListsSlowCase to rebuildZOrderLists

Modified: trunk/Source/WebCore/editing/Editor.cpp (114310 => 114311)


--- trunk/Source/WebCore/editing/Editor.cpp	2012-04-16 22:27:32 UTC (rev 114310)
+++ trunk/Source/WebCore/editing/Editor.cpp	2012-04-16 22:50:33 UTC (rev 114311)
@@ -916,7 +916,7 @@
             RefPtr<Document> document = selectionStart->document();
 
             // Insert the text
-            if (triggeringEvent->isDictation())
+            if (triggeringEvent && triggeringEvent->isDictation())
                 DictationCommand::insertText(document.get(), text, triggeringEvent->dictationAlternatives(), selection);
             else {
                 TypingCommand::Options options = 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to