Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cb6bc66054e7b006e06f884d49dacb0deb44774c
https://github.com/WebKit/WebKit/commit/cb6bc66054e7b006e06f884d49dacb0deb44774c
Author: Zak Ridouh <[email protected]>
Date: 2026-02-28 (Sat, 28 Feb 2026)
Changed paths:
M LayoutTests/resources/ui-helper.js
M Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
M Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h
M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm
M Tools/WebKitTestRunner/mac/UIScriptControllerMac.h
M Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm
Log Message:
-----------
Add isShowingColorPicker UIScriptController hook and
waitForColorPickerToPresent UIHelper
https://bugs.webkit.org/show_bug.cgi?id=308717
rdar://171246897
Reviewed by Aditya Keerthi.
Add a isShowingColorPicker hook to UIScriptController so tests can
deterministically wait for the color picker.
On macOS, detection checks for WKPopoverColorWell in the window's view
hierarchy. On iOS, it checks whether the presented view controller is a
UIColorPickerViewController.
UIHelper.waitForColorPickerToPresent() uses willPresentPopoverCallback on
iOS and async polling on macOS.
* LayoutTests/resources/ui-helper.js:
(window.UIHelper.isShowingColorPicker):
(window.UIHelper.waitForColorPickerToPresent.return.new.Promise):
(window.UIHelper.waitForColorPickerToPresent):
(window.UIHelper.enterText): Deleted.
* Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::isShowingColorPicker const):
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h:
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::isShowingColorPicker const):
* Tools/WebKitTestRunner/mac/UIScriptControllerMac.h:
* Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptControllerMac::isShowingColorPicker const):
Canonical link: https://commits.webkit.org/308409@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
