Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9f52430ba166973b43555c92a29d55b24bf910c0
https://github.com/WebKit/WebKit/commit/9f52430ba166973b43555c92a29d55b24bf910c0
Author: Tim Nguyen <[email protected]>
Date: 2026-02-28 (Sat, 28 Feb 2026)
Changed paths:
M Source/WebCore/dom/Element.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp
M Source/WebCore/rendering/updating/RenderTreePosition.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp
M Source/WebCore/style/Styleable.cpp
Log Message:
-----------
Generalize pseudo-element renderer pointer storage
https://bugs.webkit.org/show_bug.cgi?id=308865
rdar://171407918
Reviewed by Simon Fraser.
As we add more pseudo-elements, we'll want efficient renderer lookups:
- to determine the render tree position (see ::picker-icon usage in
RenderTreePosition)
- to find pre-existing renderer for destruction
- to add animation support (see Styleable.cpp usages)
Create a map from PseudoElementType -> SingleThreadedWeakPtr<RenderBlockFlow>
and replace the ::backdrop / ::picker-icon pointers.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::removeFromTopLayer):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::fixedContainerEdges const):
(WebCore::LocalFrameView::documentBackgroundColor const):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeForHitTest const):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::pseudoElementRendererIndex):
(WebCore::RenderElement::pseudoElementRenderer const):
(WebCore::RenderElement::setPseudoElementRenderer):
(WebCore::RenderElement::backdropRenderer const): Deleted.
(WebCore::RenderElement::setBackdropRenderer): Deleted.
(WebCore::RenderElement::pickerIconRenderer const): Deleted.
(WebCore::RenderElement::setPickerIconRenderer): Deleted.
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderLayer.cpp:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::isDescendantOfFullScreenLayer):
* Source/WebCore/rendering/RenderObject.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp:
(WebCore::RenderTreeBuilder::FormControls::updatePseudoElement):
* Source/WebCore/rendering/updating/RenderTreePosition.cpp:
(WebCore::RenderTreePosition::nextSiblingRenderer const):
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::repaintAndMarkContainingBlockDirtyBeforeTearDown):
(WebCore::RenderTreeUpdater::tearDownRenderersInternal):
* Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::updateBackdropRenderer):
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::fromRenderer):
(WebCore::Styleable::renderer const):
Canonical link: https://commits.webkit.org/308412@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
