Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4f51c89e3c773af6ea3a556ba0ce11540368b319
https://github.com/WebKit/WebKit/commit/4f51c89e3c773af6ea3a556ba0ce11540368b319
Author: Vassili Bykov <[email protected]>
Date: 2026-02-28 (Sat, 28 Feb 2026)
Changed paths:
A LayoutTests/http/tests/wasm/wasm-js-string-builtins-streaming-expected.txt
A LayoutTests/http/tests/wasm/wasm-js-string-builtins-streaming.html
M Source/JavaScriptCore/CMakeLists.txt
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/JavaScriptCore/builtins/WebAssembly.js
M Source/JavaScriptCore/runtime/GlobalObjectMethodTable.h
M Source/JavaScriptCore/tools/JSDollarVM.cpp
M Source/JavaScriptCore/wasm/WasmStreamingCompiler.cpp
M Source/JavaScriptCore/wasm/WasmStreamingCompiler.h
M Source/JavaScriptCore/wasm/js/JSWebAssembly.cpp
M Source/JavaScriptCore/wasm/js/WebAssemblyCompileOptions.h
M Source/WebCore/bindings/js/JSDOMGlobalObject.cpp
M Source/WebCore/bindings/js/JSDOMGlobalObject.h
A Source/WebKit/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
Log Message:
-----------
[JSC] Fix WebAssembly.compileStreaming and .instantiateStreaming to accept
compileOptions
https://bugs.webkit.org/show_bug.cgi?id=308136
rdar://170989896
Reviewed by Marcus Plutowski.
[Re-landing an earlier PR #59278. This iteration adds SaferCPP expectations for
source files, most
of them under DerivedSources, in which SaferCPP started detecting uncounted
args and vars. These
files are unrelated to the patch, but an added #include made SaferCPP detect
issues that previously
went unnoticed]:
* Source/WebKit/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations:
Added.
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
This patch adds the support required by the JS string builtin proposal to the
streaming
compilation and instantiation APIs of WebAssembly (defined in the Web Embedding
rather
than the JavaScript Embedding document of the proposal).
Highlights:
Added support for the optional compileOptions parameter to the JS builtins and
the underlying internal functions in:
* Source/JavaScriptCore/builtins/WebAssembly.js
* Source/JavaScriptCore/wasm/js/JSWebAssembly.cpp:
Added the plumbing to carry the options from the JS builtins to the streaming
compiler (function signature changes in multiple places).
Added the handling of compileOptions to:
* Source/JavaScriptCore/wasm/WasmStreamingCompiler.cpp:
* Source/JavaScriptCore/wasm/WasmStreamingCompiler.h:
Added tests:
* LayoutTests/http/tests/wasm/wasm-js-string-builtins-streaming.html
Canonical link: https://commits.webkit.org/308419@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
