Title: [114316] trunk/Source/WebCore
Revision
114316
Author
x...@chromium.org
Date
2012-04-16 16:32:16 -0700 (Mon, 16 Apr 2012)

Log Message

platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
https://bugs.webkit.org/show_bug.cgi?id=83521

Reviewed by David Levin.

No functionality change, so no new tests.

* platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
(WebCore::GlyphPage::fill):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (114315 => 114316)


--- trunk/Source/WebCore/ChangeLog	2012-04-16 23:24:15 UTC (rev 114315)
+++ trunk/Source/WebCore/ChangeLog	2012-04-16 23:32:16 UTC (rev 114316)
@@ -1,3 +1,15 @@
+2012-04-16  Xiaomei Ji  <x...@chromium.org>
+
+        platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
+        https://bugs.webkit.org/show_bug.cgi?id=83521
+
+        Reviewed by David Levin.
+
+        No functionality change, so no new tests.
+
+        * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
+        (WebCore::GlyphPage::fill):
+
 2012-04-16  Levi Weintraub  <le...@chromium.org>
 
         Make borderBoxRect sub-pixel precise and add a pixel snapped version

Modified: trunk/Source/WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp (114315 => 114316)


--- trunk/Source/WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp	2012-04-16 23:24:15 UTC (rev 114315)
+++ trunk/Source/WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp	2012-04-16 23:32:16 UTC (rev 114316)
@@ -96,15 +96,12 @@
     }
 
     if (fontData->hasVerticalGlyphs()) {
-        bool lookVariants = false;
         for (unsigned i = 0; i < bufferLength; ++i) {
             if (!Font::isCJKIdeograph(buffer[i])) {
-                lookVariants = true;
-                continue;
+                substituteWithVerticalGlyphs(fontData, glyphs, length);
+                break;
             }
         }
-        if (lookVariants)
-            substituteWithVerticalGlyphs(fontData, glyphs, length);
     }
 
     unsigned allGlyphs = 0; // track if any of the glyphIDs are non-zero
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to