Skip to site navigation (Press enter)
[webkit-changes] [WebKit/WebKit] 3a7fd8: and
/<frame> pixel-length margin at...</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=webkit-changes@lists.webkit.org&q=from:%22Ahmad+Saleem%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">Ahmad Saleem</span></span></a></span> <span class="date"><a href="/search?l=webkit-changes@lists.webkit.org&q=date:20260302" rel="nofollow">Mon, 02 Mar 2026 23:54:17 -0800</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre> Branch: refs/heads/main Home: <a rel="nofollow" href="https://github.com/WebKit/WebKit">https://github.com/WebKit/WebKit</a> Commit: 3a7fd86e2a6810aa8376d1de3703dcd6e63195a1 <a rel="nofollow" href="https://github.com/WebKit/WebKit/commit/3a7fd86e2a6810aa8376d1de3703dcd6e63195a1">https://github.com/WebKit/WebKit/commit/3a7fd86e2a6810aa8376d1de3703dcd6e63195a1</a> Author: Ahmad Saleem <ahmad.saleem792+git...@gmail.com> Date: 2026-03-02 (Mon, 02 Mar 2026)</pre><pre> Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/rendering/pixel-length-attributes-expected.txt R LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/pixel-length-attributes-expected.txt M Source/WebCore/html/HTMLAttributeNames.in M Source/WebCore/html/HTMLBodyElement.cpp M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLElement.h M Source/WebCore/html/HTMLFrameElementBase.cpp Log Message: ----------- <body> and <iframe>/<frame> pixel-length margin attributes parsed incorrectly <a rel="nofollow" href="https://bugs.webkit.org/show_bug.cgi?id=308708">https://bugs.webkit.org/show_bug.cgi?id=308708</a> rdar://171240848 Reviewed by Ryosuke Niwa. The HTML spec defines "maps to the pixel length property" using the rules for parsing non-negative integers, not the rules for parsing dimension values. Previously, `addHTMLLengthToStyle` (which uses `parseHTMLDimension`) was used for `marginwidth`, `marginheight`, `leftmargin`, `topmargin`, `rightmargin`, and `bottommargin` on `<body>`. This incorrectly accepted fractional values ("200.25" → "200.25px"), percentage values ("200%" → "200%"), and the `+` prefix ("+200" → "200px"). Non-negative integer parsing rejects all of these. Additionally, `rightmargin` and `bottommargin` on `<body>` were entirely unimplemented: missing from `HTMLAttributeNames.in`, `hasPresentationalHintsForAttribute`, and `collectPresentationalHintsForAttribute`. The spec requires: "For each property in the table below, given a body element, the first attribute that exists maps to the pixel length property on the body element. If none of the attributes for a property are found, or if the value of the attribute that was found cannot be parsed successfully, then a default value of 8px is expected to be used for that property instead." — <a rel="nofollow" href="https://html.spec.whatwg.org/multipage/rendering.html#the-body-element-2">https://html.spec.whatwg.org/multipage/rendering.html#the-body-element-2</a> Also, `marginwidth`/`marginheight` changes on `<iframe>`/`<frame>` after insertion were not propagated to the content document's `<body>`. Fix by introducing `HTMLElement::addHTMLPixelLengthToStyle` which uses `parseHTMLNonNegativeInteger`, adding `rightmargin`/`bottommargin` to the attribute registry and presentational hint pipeline, and propagating `marginwidth`/`marginheight` attribute changes dynamically in `HTMLFrameElementBase::attributeChanged`. * Source/WebCore/html/HTMLAttributeNames.in: * Source/WebCore/html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::hasPresentationalHintsForAttribute const): (WebCore::HTMLBodyElement::collectPresentationalHintsForAttribute): * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::addHTMLPixelLengthToStyle): * Source/WebCore/html/HTMLElement.h: * Source/WebCore/html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::attributeChanged): * LayoutTests/imported/w3c/web-platform-tests/html/rendering/pixel-length-attributes-expected.txt: Progression * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/pixel-length-attributes-expected.txt: Removed. Canonical link: <a rel="nofollow" href="https://commits.webkit.org/308526@main">https://commits.webkit.org/308526@main</a> To unsubscribe from these emails, change your notification settings at <a rel="nofollow" href="https://github.com/WebKit/WebKit/settings/notifications">https://github.com/WebKit/WebKit/settings/notifications</a> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg244945.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="index.html#244946">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#244946">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg244947.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[webkit-changes] [WebKit/WebKit] 3a7fd8: <body> and <iframe>/<frame> pixel-length margin at..."> <input type="hidden" name="msgid" value="WebKit/WebKit/push/refs/heads/main/0a40f4-3a7fd8@github.com"> <input type="hidden" name="relpath" value="webkit-changes@lists.webkit.org/msg244946.html"> <input type="submit" value=" Ahmad Saleem "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="webkit-changes@lists.webkit.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search webkit-changes"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/webkit-changes@lists.webkit.org/">webkit-changes - all messages</a></li> <li class="icons-about"><a href="/webkit-changes@lists.webkit.org/info.html">webkit-changes - about the list</a></li> <li class="icons-expand"><a href="/search?l=webkit-changes@lists.webkit.org&q=subject:%22%5C%5Bwebkit%5C-changes%5C%5D+%5C%5BWebKit%5C%2FWebKit%5C%5D+3a7fd8%5C%3A+%3Cbody%3E+and+%3Ciframe%3E%5C%2F%3Cframe%3E+pixel%5C-length+margin+at...%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg244945.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg244947.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">WebKit/WebKit/push/refs/heads/main/0a40f4-3a7fd8@github.com</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9d9c3f867a45b86e',t:'MTc3MzA4MjA0Ng=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>