Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3ef66918061f8ca7f977e0cd81c8e61ec7ff3018
https://github.com/WebKit/WebKit/commit/3ef66918061f8ca7f977e0cd81c8e61ec7ff3018
Author: Ahmad Saleem <[email protected]>
Date: 2026-03-03 (Tue, 03 Mar 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/height-distribution/computing-row-measure-0-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/tentative/table-height-redistribution-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/tentative/tbody-height-redistribution-expected.txt
M
LayoutTests/platform/glib/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt
M
LayoutTests/platform/glib/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt
M
LayoutTests/platform/glib/tables/mozilla_expected_failures/bugs/bug51000-expected.txt
M
LayoutTests/platform/glib/tables/mozilla_expected_failures/other/test4-expected.txt
M
LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt
M
LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt
M
LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug51000-expected.txt
M
LayoutTests/platform/ios/tables/mozilla_expected_failures/other/test4-expected.txt
M
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt
M
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt
M
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug51000-expected.txt
M
LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt
M Source/WebCore/rendering/RenderTableSection.cpp
Log Message:
-----------
Table sections with explicit height should constrain contained rows
https://bugs.webkit.org/show_bug.cgi?id=306592
rdar://169235210
Reviewed by Alan Baradlay.
When a table section (tbody, thead, or tfoot) has an explicit height
that is larger than the natural height of its rows, the extra space
should be distributed among the rows. Previously, the section's own
height constraint was ignored, causing the section to collapse to
only the natural height of its rows.
According to the CSS Tables Level 3 specification for "Computing row
measures" [1], the table section's height should be max(section height,
sum of row heights).
This fix ensures that after calculating row heights in layoutRows(),
we check if the section has an explicit fixed height. If that height
exceeds the sum of row heights, we distribute the extra space to the
rows using the existing distributeExtraLogicalHeightToRows() method.
[1] https://drafts.csswg.org/css-tables-3/#computing-the-table-width
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/height-distribution/computing-row-measure-0-expected.txt:
Progression
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/tentative/table-height-redistribution-expected.txt:
One test progression
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/tentative/tbody-height-redistribution-expected.txt:
Rebaseline
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
> Rebaselines:
*
LayoutTests/platform/glib/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
*
LayoutTests/platform/glib/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
*
LayoutTests/platform/glib/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
*
LayoutTests/platform/glib/tables/mozilla_expected_failures/other/test4-expected.txt:
*
LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
*
LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
*
LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
*
LayoutTests/platform/ios/tables/mozilla_expected_failures/other/test4-expected.txt:
*
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
*
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
*
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
*
LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
Canonical link: https://commits.webkit.org/308540@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
