Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 94a006e089056d10f442b9a9d173560fc7097505
https://github.com/WebKit/WebKit/commit/94a006e089056d10f442b9a9d173560fc7097505
Author: Ahmad Saleem <[email protected]>
Date: 2026-03-03 (Tue, 03 Mar 2026)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/RenderBox.cpp
Log Message:
-----------
Percentage height children of table cells with unresolvable percentage
heights should size intrinsically
https://bugs.webkit.org/show_bug.cgi?id=308930
rdar://171469500
Reviewed by Alan Baradlay.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
When a table cell has a percentage height (e.g. height:100%) and the
table itself has auto height, that percentage is unresolvable. Children
of such cells with overflow:auto and height:100% should treat the
percentage as unresolvable and size intrinsically.
Two issues fixed:
1. tableCellShouldHaveZeroInitialSize() only returned false when both
the cell and table had auto heights. A cell with an unresolvable
percentage height (percentage against an auto-height table) should
be treated the same as auto — the child should not collapse to zero.
2. computePercentageLogicalHeightGeneric() unconditionally used the
cell's overridingBorderBoxLogicalHeight (set by row layout) to
resolve children's percentage heights. When the cell's own percentage
height is unresolvable, the override should not be used, otherwise
children stretch to the row height determined by sibling cells.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::tableCellShouldHaveZeroInitialSize):
(WebCore::RenderBox::computePercentageLogicalHeightGeneric const):
* LayoutTests/TestExpectations: Progressions
Canonical link: https://commits.webkit.org/308547@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
