Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 523a8fb63dc2811c92bea9da2e623e7871f299d5
https://github.com/WebKit/WebKit/commit/523a8fb63dc2811c92bea9da2e623e7871f299d5
Author: Tim Nguyen <[email protected]>
Date: 2026-03-03 (Tue, 03 Mar 2026)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-style-containment-001-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-base-appearance-computed-style-expected.txt
M Source/WebCore/css/html.css
M Source/WebCore/rendering/RenderCounter.cpp
Log Message:
-----------
Counters don't work from ::checkmark/::picker-icon pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=307170
rdar://169804965
Reviewed by Darin Adler.
Newer pseudo-elements are not backed by DOM elements, so DOM traversals in
RenderCounter would fail to find those.
Use renderer traversals instead of DOM element based-ones.
As a result of using renderer traversals, we also progress tests that expect
the flat tree to be used for slots & display: contents.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-style-containment-001-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-base-appearance-computed-style-expected.txt:
* Source/WebCore/css/html.css:
(select::picker-icon):
* Source/WebCore/rendering/RenderCounter.cpp:
(WebCore::lastDescendantRespectingContainment):
(WebCore::previousInPreOrderRespectingContainment):
(WebCore::lastDescendantInAnonymousBlock):
(WebCore::previousSiblingUnwrappingAnonymous):
(WebCore::previousSiblingOrParentSkippingAnonymous):
(WebCore::previousSiblingOrParent):
(WebCore::areRenderersElementsSiblings):
(WebCore::nextInPreOrder):
(WebCore::planCounter):
(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
(WebCore::RenderCounter::originalText const):
(WebCore::RenderCounter::updateCounter):
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::rendererStyleChangedSlowCase):
(WebCore::ancestorStyleContainmentObject): Deleted.
(WebCore::parentOrPseudoHostElement):
(WebCore::previousSiblingOrParentElement): Deleted.
Canonical link: https://commits.webkit.org/308563@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
