Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 851a40d30f33e8a89df17c100fd7ce49e40ee01e
https://github.com/WebKit/WebKit/commit/851a40d30f33e8a89df17c100fd7ce49e40ee01e
Author: Jer Noble <[email protected]>
Date: 2026-03-03 (Tue, 03 Mar 2026)
Changed paths:
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M
Tools/TestWebKitAPI/Tests/WebCore/cocoa/MediaPlayerPrivateAVFoundationObjCTests.mm
Log Message:
-----------
REGRESSION(306825@main): [Cocoa] HLS videos stutter when toggling muted
rdar://171093593
https://bugs.webkit.org/show_bug.cgi?id=309043
Reviewed by Jean-Yves Avenard.
Toggling the value of AVPlayer.suppressesAudioRendering causes AVFoundation to
perturb
the timebase driving the video rendering. Previously, we would only set that
property
to true during initialization, and we would set it back to false the first time
the
video was unmuted. In 306825@main, we started toggling that property whenever
the volume
or muted values changed, which caused video to stutter.
Restore the previous behavior, to an extent, by only updating isAudible when a)
the video
is paused or b) when moving from not audible to audible.
Test:
Tools/TestWebKitAPI/Tests/WebCore/cocoa/MediaPlayerPrivateAVFoundationObjCTests.mm
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setPlayerRate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateIsAudible):
(WebCore::MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange):
*
Tools/TestWebKitAPI/Tests/WebCore/cocoa/MediaPlayerPrivateAVFoundationObjCTests.mm:
(TestWebKitAPI::MediaPlayerPrivateAVFoundationObjCTest::waitForCurrentTimeGreaterThan):
(TestWebKitAPI::MediaPlayerPrivateAVFoundationObjCTest::waitForEffectiveRateGreaterThan):
(TestWebKitAPI::MediaPlayerPrivateAVFoundationObjCTest::waitForEffectiveRateEqualTo):
(TestWebKitAPI::TEST_F(MediaPlayerPrivateAVFoundationObjCTest,
IsAudibleWhilePlaying)):
Canonical link: https://commits.webkit.org/308572@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
