Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 527ceabbd83369ff70d22643846770c0d3055ebb
https://github.com/WebKit/WebKit/commit/527ceabbd83369ff70d22643846770c0d3055ebb
Author: Jessica Cheung <[email protected]>
Date: 2026-03-03 (Tue, 03 Mar 2026)
Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm
Log Message:
-----------
REGRESSION(308357@main):
editing/pasteboard/data-transfer-set-data-sanitize-html-when-dragging-in-null-origin.html
crashes on Debug wk1
https://bugs.webkit.org/show_bug.cgi?id=309080
rdar://171634734
Reviewed by Wenson Hsieh and Megan Gardner.
The code in WK1 does not seem to factor/consider subframes.
The crash is an assert, which expects [self _isTopHTMLView]
to be true. This is the case when main frame is passed into startDrag,
so when non-main frames (changed in 308357@main) are passed into startDrag,
the self is no longer the topHTMLView.
Thus, to preserve the old logic, get the main frame of the
localFrame passed into startDrag and use that instead.
Also, update the TestExpectations to expect pass again.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):
Canonical link: https://commits.webkit.org/308592@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
