Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8daebc91c7d6e0dd796156986ccd7e615cd5d9cb
https://github.com/WebKit/WebKit/commit/8daebc91c7d6e0dd796156986ccd7e615cd5d9cb
Author: Yulun Wu <[email protected]>
Date: 2026-03-04 (Wed, 04 Mar 2026)
Changed paths:
A LayoutTests/fast/grid/grid-definite-minimum-size-expected.txt
A LayoutTests/fast/grid/grid-definite-minimum-size.html
M Source/WebCore/layout/formattingContexts/grid/GridLayout.cpp
M Source/WebCore/layout/formattingContexts/grid/TrackSizingAlgorithm.cpp
M Source/WebCore/layout/formattingContexts/grid/TrackSizingAlgorithm.h
Log Message:
-----------
[GFC] Correctly handle track sizing with indefinite size but definite minimum
size
https://bugs.webkit.org/show_bug.cgi?id=308688
<rdar://171219386>
Reviewed by Sammy Gill.
This PR fixes a bug where we would hit ASSERT_NOT_IMPLEMENTED() when sizing
grid tracks in GFC if the free space is indefinite but the grid container has
a definite minimum size (min-width with fr tracks).
This PR fixes this bug by:
1. properly handling Style::GridTrackBreadth::Flex in
rowSizesForFirstIterationColumnSizing by treating it as indefinite.
2. passing containerMinimumSize to sizeTracks() to correctly
compute free space when stretching auto tracks.
https://drafts.csswg.org/css-grid-1/#algo-stretch
Combined changes:
* LayoutTests/fast/grid/grid-definite-minimum-size-expected.txt: Added.
* LayoutTests/fast/grid/grid-definite-minimum-size.html: Added.
* Source/WebCore/layout/formattingContexts/grid/GridLayout.cpp:
(WebCore::Layout::rowSizesForFirstIterationColumnSizing):
(WebCore::Layout::GridLayout::performGridSizingAlgorithm const):
* Source/WebCore/layout/formattingContexts/grid/TrackSizingAlgorithm.cpp:
(WebCore::Layout::TrackSizingAlgorithm::sizeTracks):
* Source/WebCore/layout/formattingContexts/grid/TrackSizingAlgorithm.h:
Canonical link: https://commits.webkit.org/308657@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
