Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bf8388916cc3498f921f27882682bd2948ecab48
https://github.com/WebKit/WebKit/commit/bf8388916cc3498f921f27882682bd2948ecab48
Author: Richard Robinson <[email protected]>
Date: 2026-03-04 (Wed, 04 Mar 2026)
Changed paths:
M Source/WebCore/page/EditorClient.h
M Source/WebCore/page/EventHandler.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKit
Swift/TestWebKitAPIBundle-Bridging-Header.h
A Tools/TestWebKitAPI/Tests/WebKitCocoa/AppKitGestures.mm
A Tools/TestWebKitAPI/Tests/WebKitCocoa/AppKitGesturesSupport.h
A Tools/TestWebKitAPI/Tests/WebKitCocoa/AppKitGesturesSupport.swift
M Tools/TestWebKitAPI/WebPage+Extras.swift
Log Message:
-----------
[AppKit Gestures] Clicks in text Mail compose window to move insertion point
not always going through
https://bugs.webkit.org/show_bug.cgi?id=309143
rdar://171626443
Reviewed by Abrar Rahman Protyasha.
The logic that was recently changed in
`WebPage::shouldAllowSingleClickToChangeSelection` for macOS should have only
been applied
for Automation-type mouse events.
Fix by reverting to prior correct behavior for mouse events that are not
Automation.
Tests: Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Tools/TestWebKitAPI/Tests/WebKit
Swift/TestWebKitAPIBundle-Bridging-Header.h
Tools/TestWebKitAPI/Tests/WebKitCocoa/AppKitGestures.mm
Tools/TestWebKitAPI/Tests/WebKitCocoa/AppKitGesturesSupport.h
Tools/TestWebKitAPI/Tests/WebKitCocoa/AppKitGesturesSupport.swift
* Source/WebCore/page/EditorClient.h:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
* Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldAllowSingleClickToChangeSelection const):
* Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::shouldAllowSingleClickToChangeSelection):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldAllowSingleClickToChangeSelection const):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit Swift/TestWebKitAPIBundle-Bridging-Header.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/AppKitGestures.mm: Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/AppKitGesturesSupport.h: Copied from
Tools/TestWebKitAPI/Tests/WebKit Swift/TestWebKitAPIBundle-Bridging-Header.h.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/AppKitGesturesSupport.swift: Added.
(AppKitGesturesSupport.testClickingChangesSelection):
Canonical link: https://commits.webkit.org/308681@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
