Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 23fcca439970c347c6c96604fcdfc2db8d1e24a3
https://github.com/WebKit/WebKit/commit/23fcca439970c347c6c96604fcdfc2db8d1e24a3
Author: Anuj Panta <[email protected]>
Date: 2026-03-05 (Thu, 05 Mar 2026)
Changed paths:
M LayoutTests/inspector/console/js-completions-expected.txt
M LayoutTests/inspector/console/js-completions.html
M
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js
Log Message:
-----------
Web Inspector: JavaScriptRuntimeCompletionProvider doesn't handle null
propertyNames from callFunctionOn
https://bugs.webkit.org/show_bug.cgi?id=309085
rdar://171639265
Reviewed by Devin Rousso and BJ Burg.
receivedObjectPropertyNames calls Object.keys(propertyNames) without a null
check,
unlike receivedPropertyNamesFromEvaluate and receivedArrayPropertyNames which
already
guard against null.
* LayoutTests/inspector/console/js-completions-expected.txt:
* LayoutTests/inspector/console/js-completions.html:
*
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.):
(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedArrayPropertyNames):
Deleted.
Canonical link: https://commits.webkit.org/308703@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
