Title: [114342] trunk/Source/WebCore
Revision
114342
Author
[email protected]
Date
2012-04-16 22:08:58 -0700 (Mon, 16 Apr 2012)

Log Message

Auto-sized frames may be taller than expected
https://bugs.webkit.org/show_bug.cgi?id=84106

Patch by Andrei Burago <[email protected]> on 2012-04-16
Reviewed by David Levin.

No new tests. The repro steps require using Chrome notifications on Win.

* page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (114341 => 114342)


--- trunk/Source/WebCore/ChangeLog	2012-04-17 05:08:25 UTC (rev 114341)
+++ trunk/Source/WebCore/ChangeLog	2012-04-17 05:08:58 UTC (rev 114342)
@@ -1,3 +1,15 @@
+2012-04-16  Andrei Burago  <[email protected]>
+
+        Auto-sized frames may be taller than expected
+        https://bugs.webkit.org/show_bug.cgi?id=84106
+
+        Reviewed by David Levin.
+
+        No new tests. The repro steps require using Chrome notifications on Win.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::autoSizeIfEnabled):
+
 2012-04-13  James Robinson  <[email protected]>
 
         [chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it

Modified: trunk/Source/WebCore/page/FrameView.cpp (114341 => 114342)


--- trunk/Source/WebCore/page/FrameView.cpp	2012-04-17 05:08:25 UTC (rev 114341)
+++ trunk/Source/WebCore/page/FrameView.cpp	2012-04-17 05:08:58 UTC (rev 114342)
@@ -2433,12 +2433,13 @@
     if (!m_didRunAutosize)
         resize(frameRect().width(), m_minAutoSize.height());
 
+    IntSize size = frameRect().size();
+
     // Do the resizing twice. The first time is basically a rough calculation using the preferred width
     // which may result in a height change during the second iteration.
     for (int i = 0; i < 2; i++) {
         // Update various sizes including contentsSize, scrollHeight, etc.
         document->updateLayoutIgnorePendingStylesheets();
-        IntSize size = frameRect().size();
         int width = documentView->minPreferredLogicalWidth();
         int height = documentRenderBox->scrollHeight();
         IntSize newSize(width, height);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to