Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1927f6c9ffc4112f9022bedc27d88abf79321d5d
https://github.com/WebKit/WebKit/commit/1927f6c9ffc4112f9022bedc27d88abf79321d5d
Author: Lauro Moura <[email protected]>
Date: 2026-03-05 (Thu, 05 Mar 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/glib.py
M Tools/Scripts/webkitpy/port/gtk.py
M Tools/Scripts/webkitpy/port/gtk_unittest.py
M Tools/Scripts/webkitpy/port/wpe.py
M Tools/Scripts/webkitpy/port/wpe_unittest.py
Log Message:
-----------
[webkitpy][GLIB] Fix architecture field value for glib Port classes
https://bugs.webkit.org/show_bug.cgi?id=309249
Reviewed by Carlos Alberto Lopez Perez.
Replace the currently hardcoded x86 architecture with runtime detection.
This fixes the results uploaded by the new ARM64 testers (307868@main).
Currently, they have the same x86 architecture as the x86_64, making it
hard to follow the history, especially when the outcome differ. For
example, while the x86_64 bot is in a good shape, queries to the
results database showed alternating green and red runs.
This commit also expands the list of test configurations for the glib
ports, covering both the default x86_64 and arm64 architectures, and
enabling architecture-specific expectations within the same expectation
file, for example:
[ arm64 ] some/test.html [ Crash ]
* Tools/Scripts/webkitpy/port/glib.py:
(GLibPort):
(GLibPort.architecture):
(GLibPort._generate_all_test_configurations):
* Tools/Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
(GtkPort._generate_all_test_configurations): Deleted.
* Tools/Scripts/webkitpy/port/gtk_unittest.py:
(GtkPortTest.test_architecture_default):
(GtkPortTest):
(GtkPortTest.test_architecture_cli_override):
(GtkPortTest.test_architecture_aarch64_normalization):
(GtkPortTest.test_architecture_cli_override_aarch64):
(GtkPortTest.test_all_test_configurations_architectures):
* Tools/Scripts/webkitpy/port/wpe.py:
(WPEPort.check_sys_deps):
(WPEPort._generate_all_test_configurations): Deleted.
* Tools/Scripts/webkitpy/port/wpe_unittest.py:
(WPEPortTest.test_architecture_default):
(WPEPortTest):
(WPEPortTest.test_architecture_cli_override):
(WPEPortTest.test_architecture_aarch64_normalization):
(WPEPortTest.test_architecture_cli_override_aarch64):
(WPEPortTest.test_all_test_configurations_architectures):
Canonical link: https://commits.webkit.org/308721@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
