Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cef91b6c3f112a1d1b16a133860c08b2a7c130ee
https://github.com/WebKit/WebKit/commit/cef91b6c3f112a1d1b16a133860c08b2a7c130ee
Author: Yusuke Suzuki <[email protected]>
Date: 2026-03-05 (Thu, 05 Mar 2026)
Changed paths:
M Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.cpp
M Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
M Source/JavaScriptCore/runtime/JSMicrotask.cpp
M Source/JavaScriptCore/runtime/JSPromise.cpp
M Source/JavaScriptCore/runtime/JSPromise.h
M Source/JavaScriptCore/runtime/JSStringIterator.cpp
Log Message:
-----------
[JSC] Clean up and micro-optimize JSPromise code in C++
https://bugs.webkit.org/show_bug.cgi?id=309278
rdar://171826016
Reviewed by Yijia Huang.
Super carefully looking into the code and profiler samples and doing
micro-optimization for JSPromise.
1. When setting state (jsNumber), do not use WriteBarrier::set as it is
never a JSCell.
2. Use int32_t instead of uint32_t, which removes some checks to fold it
into JSValue.
3. markAsHandled is only necessary when JSPromise is pending or
rejected.
* Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
* Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
* Source/JavaScriptCore/runtime/JSMicrotask.cpp:
(JSC::runInternalMicrotask):
* Source/JavaScriptCore/runtime/JSPromise.cpp:
(JSC::JSPromise::resolve):
(JSC::JSPromise::reject):
(JSC::JSPromise::fulfill):
(JSC::JSPromise::performPromiseThen):
(JSC::JSPromise::performPromiseThenWithInternalMicrotask):
(JSC::JSPromise::rejectPromise):
(JSC::JSPromise::fulfillPromise):
* Source/JavaScriptCore/runtime/JSPromise.h:
(JSC::JSPromise::initialValues):
(JSC::JSPromise::status const):
(JSC::JSPromise::markAsHandled):
(JSC::JSPromise::flags const):
* Source/JavaScriptCore/runtime/JSStringIterator.cpp:
(JSC::JSStringIterator::finishCreation):
Canonical link: https://commits.webkit.org/308762@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
