Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e1369350dab08147264e9881efbb475e48ee422
      
https://github.com/WebKit/WebKit/commit/2e1369350dab08147264e9881efbb475e48ee422
  Author: Simon Pena <[email protected]>
  Date:   2026-03-06 (Fri, 06 Mar 2026)

  Changed paths:
    M Source/WebCore/platform/gamepad/manette/ManetteGamepad.cpp
    M Source/WebCore/platform/gamepad/manette/ManetteGamepad.h
    M Source/WebCore/platform/gamepad/manette/ManetteGamepadProvider.cpp
    M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

  Log Message:
  -----------
  [GTK] Implement playEffect by supporting gamepad rumble
https://bugs.webkit.org/show_bug.cgi?id=309274

Reviewed by Carlos Garcia Campos.

Implemented playEffect (and stopEffects) using libmanette's rumble. This
gates the effect by checking if the type is supported, then applies the
right rumble parameters depending on the libmanette version used.

Tested against https://hardwaretester.com/gamepad.

* Source/WebCore/platform/gamepad/manette/ManetteGamepad.cpp:
(WebCore::ManetteGamepad::ManetteGamepad):
(WebCore::ManetteGamepad::playEffect):
(WebCore::ManetteGamepad::stopEffects):
(WebCore::ManetteGamepad::effectDelayTimerFired):
(WebCore::ManetteGamepad::startRumble):
(WebCore::ManetteGamepad::effectDurationTimerFired):
* Source/WebCore/platform/gamepad/manette/ManetteGamepad.h:
* Source/WebCore/platform/gamepad/manette/ManetteGamepadProvider.cpp:
(WebCore::ManetteGamepadProvider::removeGamepadForDevice):
(WebCore::ManetteGamepadProvider::playEffect):
(WebCore::ManetteGamepadProvider::stopEffects):
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultGamepadVibrationActuatorEnabled):

Canonical link: https://commits.webkit.org/308799@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to