Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 62f3a979e4aae387a4f5ba15568d69b2a7d1719b
https://github.com/WebKit/WebKit/commit/62f3a979e4aae387a4f5ba15568d69b2a7d1719b
Author: Dana Estra <[email protected]>
Date: 2026-03-09 (Mon, 09 Mar 2026)
Changed paths:
M Source/WebCore/Modules/modern-media-controls/media/media-controller.js
Log Message:
-----------
www.x.com unable to enter PiP mode in video recorded in vertical view after
video viewer,
exiting two arrows top left of screen and returning to video viewer to activate
PiP again
https://bugs.webkit.org/show_bug.cgi?id=309176
rdar://168793752
Reviewed by Jer Noble.
We do not allow rewinding on x.com due to the media source type not being HLS
or a file. This bug is occurring due to a missing null check on
this.controls.rewindButton.
Adding the null check allows the modern media controls script to execute
properly.
No new tests.
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype._updateControlsIfNeeded):
Canonical link: https://commits.webkit.org/308936@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
