Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 001d79b4c01575fa85c20ae474abba67571f4034
      
https://github.com/WebKit/WebKit/commit/001d79b4c01575fa85c20ae474abba67571f4034
  Author: Anne van Kesteren <[email protected]>
  Date:   2026-03-11 (Wed, 11 Mar 2026)

  Changed paths:
    M LayoutTests/TestExpectations
    M 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/open-pseudo-expected.txt
    M Tools/WebKitTestRunner/mac/TestControllerMac.mm

  Log Message:
  -----------
  WKTR: use nested event loop for PopUpMenu
https://bugs.webkit.org/show_bug.cgi?id=308884
rdar://171980750

Reviewed by Charlie Wolfe.

At the moment you cannot open a <select> on macOS from WebKitTestRunner
without it immediately closing due to how NSMenu is swizzled in
TestController::platformInitialize().

We adjust this implementation with a nested event loop, similar to how
it's handled in the browser. This works because of 308928@main,
308970@main, and 309000@main paving the way.

This also exposes an assert in
imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/switch-picker-appearance.html
and progresses
/imported/w3c/web-platform-tests/css/selectors/open-pseudo.html.

Canonical link: https://commits.webkit.org/309039@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to