Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4f4eee548d96f4ba5404afdd5e11acba00642d90
https://github.com/WebKit/WebKit/commit/4f4eee548d96f4ba5404afdd5e11acba00642d90
Author: Cole Carley <[email protected]>
Date: 2026-03-11 (Wed, 11 Mar 2026)
Changed paths:
M
LayoutTests/platform/gtk/fast/text/international/bidi-menulist-expected.txt
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/ios/fast/forms/listbox-bidi-align-expected.txt
M
LayoutTests/platform/ios/fast/text/international/bidi-menulist-expected.txt
M
LayoutTests/platform/mac-sequoia-wk2/fast/text/international/bidi-menulist-expected.txt
M
LayoutTests/platform/mac-wk2/fast/text/international/bidi-menulist-expected.txt
M
LayoutTests/platform/mac/fast/text/international/bidi-menulist-expected.txt
M
LayoutTests/platform/wpe/fast/text/international/bidi-menulist-expected.txt
M Source/WebCore/html/shadow/SelectFallbackButtonElement.cpp
M Source/WebCore/rendering/ios/RenderThemeIOS.mm
Log Message:
-----------
REGRESSION(iOS17): fast/forms/listbox-bidi-align.html is constantly failing.
https://bugs.webkit.org/show_bug.cgi?id=263662
rdar://117478129
Reviewed by Anne van Kesteren.
There were a few issues here. First, there seems to have been some system
change to font sizes.
Second, the new class SelectFallbackButtonElement was not properly setting the
text alignment.
And similarly, the internal padding was not respecting the text alignment.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/ios/fast/forms/listbox-bidi-align-expected.txt:
* Source/WebCore/html/shadow/SelectFallbackButtonElement.cpp:
(WebCore::SelectFallbackButtonElement::resolveCustomStyle):
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::popupInternalPaddingBox const):
Canonical link: https://commits.webkit.org/309054@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
