Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2e17db558ff81ee2133cd231fb1114a7545efee9
https://github.com/WebKit/WebKit/commit/2e17db558ff81ee2133cd231fb1114a7545efee9
Author: Sihui Liu <[email protected]>
Date: 2026-03-11 (Wed, 11 Mar 2026)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/WebPageProxy.h
M Tools/TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache.cpp
M Tools/TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp
M Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBInPageCache.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolationUtilities.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolationUtilities.mm
Log Message:
-----------
[Site Isolation] Unskip tests and update expectation based on page cache
enablement
https://bugs.webkit.org/show_bug.cgi?id=309623
rdar://172234926
Reviewed by Per Arne Vollan and Rupin Mittal.
Many API tests are skipped under Site Isolation because page cache is currently
disabled under Site Isolation. These
tests actually fail due to missing page cache support, not because
implementation of Site Isolation is incorrect -- if
we disable page cache without Site Isolation, these tests will also fail. To
make this relationship more clear, this
patch introduces new testing SPI to query whether page cache is enabled (which
is computed based on various settings),
and update the skipped tests to use that SPI instead. By doing this, if we turn
on Site Isolation wiht page cache
support later, we don't have to update the tests separately to remove the
checks for `SiteIsolationEnabled`.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _isUsingBackForwardCache]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache.cpp:
(TestWebKitAPI::TEST(WebKit, DidRemoveFrameFromHiearchyInBackForwardCache)):
* Tools/TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
(TestWebKitAPI::TEST(WebKit, FirstVisuallyNonEmptyLayoutAfterPageCacheRestore)):
* Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm:
(runGoBackAfterNavigatingSameSiteIframe):
(TEST(WKBackForwardList, PageCacheGoBackAfterNavigatingSameSiteIframe)):
(runGoBackAfterNavigatingSameSiteIframe2):
(TEST(WKBackForwardList, PageCacheGoBackAfterNavigatingSameSiteIframe2)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBInPageCache.mm:
(TEST(IndexedDB, IndexedDBInPageCache)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(-[BackForwardDelegate _webView:willGoToBackForwardListItem:inPageCache:]):
(TEST(WKNavigation, WillGoToBackForwardListItem)):
(-[BackForwardDelegateWithShouldGo
webView:shouldGoToBackForwardListItem:willUseInstantBack:completionHandler:]):
(-[BackForwardDelegateWithShouldGoSPI
_webView:shouldGoToBackForwardListItem:inPageCache:completionHandler:]):
(TEST(WKNavigation, ShouldGoToBackForwardListItem)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
((ProcessSwap, Back)):
((ProcessSwap, SuspendedPageDiesAfterBackForwardListItemIsGone)):
((ProcessSwap, SuspendedPagesInActivityMonitor)):
((ProcessSwap, ReuseSuspendedProcess)):
((ProcessSwap, SuspendedPageLimit)):
((ProcessSwap, PageCache1)):
((ProcessSwap, PageCacheAfterProcessSwapByClient)):
((ProcessSwap, PageCacheWhenNavigatingFromJS)):
((ProcessSwap, NumberOfPrewarmedProcesses)):
((ProcessSwap, NumberOfCachedProcesses)):
((ProcessSwap, GoBackToSuspendedPageWithMainFrameIDThatIsNotOne)):
((ProcessSwap,
NavigateBackAfterNavigatingAwayFromCrossOriginOpenerPolicyUsingBackForwardCache)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(TEST(ResourceLoadStatistics, BackForwardPerPageData)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolationUtilities.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolationUtilities.mm:
(isUsingBackForwardCache):
Canonical link: https://commits.webkit.org/309083@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
