Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 826329072b7dc2eae74aa481a382224373ceee9e
https://github.com/WebKit/WebKit/commit/826329072b7dc2eae74aa481a382224373ceee9e
Author: Zak Ridouh <[email protected]>
Date: 2026-03-11 (Wed, 11 Mar 2026)
Changed paths:
M Source/WebCore/html/BaseDateAndTimeInputType.cpp
M Source/WebCore/platform/DateTimeChooserParameters.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/WebDateTimePicker.cpp
M Source/WebKit/UIProcess/WebDateTimePicker.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/gtk/WebDateTimePickerGtk.cpp
M Source/WebKit/UIProcess/gtk/WebDateTimePickerGtk.h
M Source/WebKit/UIProcess/mac/WebDateTimePickerMac.h
M Source/WebKit/UIProcess/mac/WebDateTimePickerMac.mm
Log Message:
-----------
[Site Isolation] Fix datetime picker positioning in cross-origin iframes
https://bugs.webkit.org/show_bug.cgi?id=308921
rdar://171461287
Reviewed by Aditya Keerthi.
The anchorRectInRootView in DateTimeChooserParameters is
relative to the iframe's root view, but the UI process interprets it
as main-frame coordinates. Add rootFrameID to
DateTimeChooserParameters and use convertRectToMainFrameCoordinates()
in showDateTimePicker, matching the existing color picker fix. Also
store the frameID on WebDateTimePicker so
didChooseDate/didEndDateTimePicker route responses reliably instead
of using focusedOrMainFrame().
* Source/WebCore/html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::setupDateTimeChooserParameters):
* Source/WebCore/platform/DateTimeChooserParameters.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/WebDateTimePicker.cpp:
(WebKit::WebDateTimePicker::showDateTimePicker):
* Source/WebKit/UIProcess/WebDateTimePicker.h:
(WebKit::WebDateTimePicker::frameID const):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showDateTimePicker):
(WebKit::WebPageProxy::didChooseDate):
(WebKit::WebPageProxy::didEndDateTimePicker):
* Source/WebKit/UIProcess/gtk/WebDateTimePickerGtk.cpp:
(WebKit::WebDateTimePickerGtk::platformShowDateTimePicker):
(WebKit::WebDateTimePickerGtk::showDateTimePicker):
* Source/WebKit/UIProcess/gtk/WebDateTimePickerGtk.h:
* Source/WebKit/UIProcess/mac/WebDateTimePickerMac.h:
* Source/WebKit/UIProcess/mac/WebDateTimePickerMac.mm:
(WebKit::WebDateTimePickerMac::platformShowDateTimePicker):
(WebKit::WebDateTimePickerMac::showDateTimePicker):
Canonical link: https://commits.webkit.org/309104@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
